Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: test directory structure #3664

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Nov 7, 2023

What I did

How I did it

How to verify it

Commit message

refactor: test directory structure

- consolidate a bunch of different directories
- move files around
- merge `conftest.py` and `base_conftest.py`
- better organization - unit/ vs functional/ tests
- rename old `parser/` and `parser_utils/` directories

there is still more refactoring that could be done, and probably some
files could be merged / specific tests in files could be moved around,
but this commit tried to only touch the directory structure for the sake
of reducing merge conflicts in PRs which are still open

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper marked this pull request as ready for review November 7, 2023 16:41
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

Merging #3664 (45c507b) into master (806dd90) will decrease coverage by 35.73%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           master    #3664       +/-   ##
===========================================
- Coverage   89.61%   53.89%   -35.73%     
===========================================
  Files          80       80               
  Lines       11343    11343               
  Branches     2553     2553               
===========================================
- Hits        10165     6113     -4052     
- Misses        791     4699     +3908     
- Partials      387      531      +144     

see 64 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@charles-cooper charles-cooper merged commit 4dd47e3 into vyperlang:master Nov 8, 2023
83 of 84 checks passed
@charles-cooper charles-cooper deleted the refactor/tests_structure branch November 8, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants