chore: tighten bounds for setuptools_scm #3613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is a regression in 8.0.0 which results in the following invalid code being generated for vyper/version.py: ```python from __future__ import annotations __version__ : str = version : str = '0.3.11' __version_tuple__ : 'tuple[int | str, ...]' = \ version_tuple : 'tuple[int | str, ...]' = (0, 3, 11) ```
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #3613 +/- ##
=======================================
Coverage 89.12% 89.12%
=======================================
Files 86 86
Lines 11407 11407
Branches 2595 2595
=======================================
Hits 10166 10166
Misses 819 819
Partials 422 422 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fubuloubu
approved these changes
Sep 20, 2023
charles-cooper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a regression in 8.0.0 which results in the following invalid code being generated for vyper/version.py:
this is a CI blocker.
What I did
fix a linter error, for instance as seen here: https://github.com/vyperlang/vyper/actions/runs/6247580329/job/16960472804?pr=3603
How I did it
pin setuptools_scm
How to verify it
check that lint passes
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture