Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement bound= in ranges #3537

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Jul 25, 2023

What I did

implements #2527.

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper marked this pull request as ready for review July 25, 2023 18:58
@charles-cooper charles-cooper enabled auto-merge (squash) July 25, 2023 19:06
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #3537 (60a5e41) into master (019a37a) will decrease coverage by 0.15%.
The diff coverage is 85.71%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3537      +/-   ##
==========================================
- Coverage   89.15%   89.01%   -0.15%     
==========================================
  Files          85       85              
  Lines       11346    11362      +16     
  Branches     2577     2584       +7     
==========================================
- Hits        10116    10114       -2     
- Misses        811      825      +14     
- Partials      419      423       +4     
Files Changed Coverage Δ
vyper/ir/compile_ir.py 92.29% <ø> (ø)
vyper/semantics/analysis/annotation.py 90.62% <66.66%> (-0.39%) ⬇️
vyper/semantics/analysis/local.py 91.62% <87.50%> (-0.36%) ⬇️
vyper/codegen/stmt.py 89.92% <88.88%> (+0.15%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper charles-cooper merged commit d48438e into vyperlang:master Jul 25, 2023
@charles-cooper charles-cooper deleted the feat/range-bound-keyword branch July 25, 2023 21:24
@pcaversaccio
Copy link
Collaborator

Documentation is missing. We should always add documentation if a new feature, kwarg or anything else affecting the syntax is added. We can't expect people learning Vyper to dig into all PRs ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants