-
-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build for aarch64 #2687
feat: build for aarch64 #2687
Conversation
To also build official binary releases for aarch64 machines. xref: vyperlang#2675 (comment)
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #2687 +/- ##
==========================================
+ Coverage 89.09% 89.12% +0.02%
==========================================
Files 84 84
Lines 10763 10763
Branches 2452 2452
==========================================
+ Hits 9589 9592 +3
+ Misses 781 776 -5
- Partials 393 395 +2 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
note: this would break current we will have to wait for the fix in actions/runner-images#4133 to be merged before merging this. |
another issue seems to be that the pycryptodome |
it needs to be built from source - charles-cooper@c47687a |
@kelvinfan001 looks like the upstream issue was fixed! do you mind if i update this PR or would you like to work on it? |
@charles-cooper thanks for the update! Feel free to update the PR, as I am no longer working on this. |
the fix in actions/python-versions#114 only applies to >= 3.9.1
blocked on actions/setup-python#439 |
Any update on this ? Almost all new macbooks are M1 & M2 and we still don't have support for it, which is very wierd since the entire project is in python. |
Seems like all blockers are resolved, will let @charles-cooper do a final review and merge |
I don't think the blockers were resolved, there was some issue with universal2 images upstream. In any case the build needs to be revisited |
this seems to be working now, see https://github.com/vyperlang/vyper/actions/runs/5014440028/jobs/8988693913 |
What I did
Edit
Makefile
to specify target arch asuniversal2
for pyinstaller.Note: Pending fix in actions/runner-images#4133.
fixes #3305
How I did it
Add
--target-architecture=universal2
in themake freeze
rule for macOS.xref: #2675 (comment)
How to verify it
Run the workflow to build artifacts.
Description for the changelog
Create official binary releases for aarch64 machines.
Cute Animal Picture