Review comments

vyperlang · Dec 21, 2023 · 0abe8cc · 0abe8cc
1 parent cd07723
commit 0abe8cc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/tests/functional/codegen/calling_convention/test_external_contract_calls.py b/tests/functional/codegen/calling_convention/test_external_contract_calls.py
@@ -3,6 +3,7 @@
 import pytest
 from eth.codecs import abi
 
+from vyper import compile_code
 from vyper.exceptions import (
     ArgumentException,
     InvalidType,
@@ -1158,8 +1159,8 @@ def test_invalid_contract_reference_call(tx_failed, get_contract):
 def bar(arg1: address, arg2: int128) -> int128:
     return Foo(arg1).foo(arg2)
 """
-    with tx_failed(exception=UndeclaredDefinition):
-        get_contract(contract)
+    with pytest.raises(UndeclaredDefinition):
+        compile_code(contract)
 
 
 def test_invalid_contract_reference_return_type(tx_failed, get_contract):
@@ -1171,8 +1172,8 @@ def foo(arg2: int128) -> invalid: view
 def bar(arg1: address, arg2: int128) -> int128:
     return Foo(arg1).foo(arg2)
 """
-    with tx_failed(exception=UnknownType):
-        get_contract(contract)
+    with pytest.raises(UnknownType):
+        compile_code(contract)
 
 
 def test_external_contract_call_declaration_expr(get_contract):

diff --git a/tests/functional/codegen/calling_convention/test_return_tuple.py b/tests/functional/codegen/calling_convention/test_return_tuple.py
@@ -1,5 +1,6 @@
 import pytest
 
+from vyper import compile_code
 from vyper.exceptions import TypeMismatch
 
 pytestmark = pytest.mark.usefixtures("memory_mocker")
@@ -158,5 +159,5 @@ def test_tuple_return_typecheck(tx_failed, get_contract_with_gas_estimation):
 def getTimeAndBalance() -> (bool, address):
     return block.timestamp, self.balance
     """
-    with tx_failed(TypeMismatch):
-        get_contract_with_gas_estimation(code)
+    with pytest.raises(TypeMismatch):
+        compile_code(code)