Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video upload Issue - wandb #397

Closed
tbasaklar opened this issue Jun 14, 2023 · 4 comments
Closed

Video upload Issue - wandb #397

tbasaklar opened this issue Jun 14, 2023 · 4 comments

Comments

@tbasaklar
Copy link

Hi,

I was following the "Experiment Tracking" at https://docs.cleanrl.dev/get-started/experiment-tracking/

In this example, the captured videos are also uploaded to wandb. However, although I followed the exact same command, my wandb project missed the "Media" folder in "Files", hence the videos do not show up in the browser. What could be the issue here? Could you try to rerun the command in the docs page of cleanRL and see if the videos are uploaded on your side?

Thanks,

@vwxyzjn
Copy link
Owner

vwxyzjn commented Jun 14, 2023

You can probably do this

if args.track and args.capture_video:

there are some ongoing gymnasium migration stuff that might have broken the Wandb gym integration.

@tbasaklar
Copy link
Author

I've also realized that if I change the command from:

python cleanrl/ppo.py --seed 1 --env-id CartPole-v1 --track --capture-video

to

python cleanrl/dqn.py --seed 1 --env-id CartPole-v1 --track --capture-video

It works! I wondered why that happened and realized it was because of the gymnasium migration, as you mentioned.
For dqn.py, the migration to the gymnasium is completed, I guess, and that's why it works.

I've also added the following condition (in ppo_continuous_action.py) to ppo.py. It works now!

Thanks,

@tbasaklar
Copy link
Author

Hi,

I appreciate the work, and I really love to work with cleanRL, especially for research purposes. When do you think you can complete the gymnasium migration for all algorithms? It is hard to follow the examples when they give errors related to Gymnasium and Gym discrepancies.

Best,

@vwxyzjn
Copy link
Owner

vwxyzjn commented Nov 28, 2023

#424 should have completed the migration for almost all.

@vwxyzjn vwxyzjn closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants