Refactor to use tyro #424
Merged
Refactor to use tyro #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sdpkjc
reviewed
Oct 16, 2023
| args = tyro.cli(Args) | ||
| args.batch_size = int(args.num_envs * args.num_steps) | ||
| args.minibatch_size = int(args.batch_size // args.num_minibatches) | ||
| args.num_iterations = args.total_timesteps // args.batch_size |
There was a problem hiding this comment.
args.num_iterations does not appear to replace the previous num_updates. Defined but not used.
18 tasks
|
Closes #418 too (added CI for 3.8, 3.9, 3.10) |
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Better code, IDE support via
tyro. Also refactors PPO and closes #206Gonna do #408 separately.
I also got to redocument ppo_atari_multigpu about the scaling log as well.
Types of changes
Checklist:
pre-commit run --all-filespasses (required).mkdocs serve.If you need to run benchmark experiments for a performance-impacting changes:
--capture-video.python -m openrlbenchmark.rlops.python -m openrlbenchmark.rlopsutility to the documentation.python -m openrlbenchmark.rlops ....your_args... --report, to the documentation.