Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to log response body & code clean-up #5

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

piranna
Copy link
Collaborator

@piranna piranna commented Apr 30, 2018

No description provided.

@vvo
Copy link
Owner

vvo commented May 15, 2018

Hi @piranna I am no more using nor maintaining this library, would you like to be the new maintainer?

@vvo
Copy link
Owner

vvo commented May 15, 2018

Also the build is broken

@piranna
Copy link
Collaborator Author

piranna commented May 15, 2018

Hi @piranna I am no more using nor maintaining this library, would you like to be the new maintainer?

That's ok for me, so far I can be able to upload new versions to npm :-)

@vvo
Copy link
Owner

vvo commented May 23, 2018

What's your npm username so I can add you?

@piranna
Copy link
Collaborator Author

piranna commented May 23, 2018

What's your npm username so I can add you?

@piranna

@vvo
Copy link
Owner

vvo commented May 23, 2018

You now have access to both GitHub and npm publish, only ensure to make the tests pass (I am all in to switch to whatever testing system you prefer like jest), maybe deprecate some old nodejs versions and let's go.

If you have no time for that, let me know too. Thanks!

@piranna
Copy link
Collaborator Author

piranna commented May 23, 2018

If you have no time for that, let me know too

I'm a little bit bussy at this moment specially because my laptop got broken yesterday, but we can start by discussing this aspects :-) Yes, I think Jest is a good option, and to prevent pitfalls, I would configure TravisCI, coveralls and Greenkeeper too, what do you think?

@vvo
Copy link
Owner

vvo commented May 23, 2018

I would configure TravisCI, coveralls and Greenkeeper too, what do you think?

Well it's super good yep. Then prettier, eslint are also great ways to make this project even more future proof. Along with instructions on how to release it so anyone can contribute to it.

I like lerna and standard-version for those kind of automation.

About greenkeeper, I am myself using renovate but if you are a greenkeeper go for it!

@vvo
Copy link
Owner

vvo commented Jun 21, 2018

@piranna let me know when you want a review, right now only missing part is README I believe, and maybe some linting/prettier installation

@piranna
Copy link
Collaborator Author

piranna commented Jun 21, 2018

I like lerna and standard-version for those kind of automation.

I don't like lerna, and for this project would not be needed. Don't know of standard-version, can you point me to it?

About greenkeeper, I am myself using renovate but if you are a greenkeeper go for it!

Interesting, do you have a link for renovate?

@piranna let me know when you want a review, right now only missing part is README I believe, and maybe some linting/prettier installation

You can take a look if you want. The last part about the text field can be removed, it was a misunderstood on my side.

@piranna
Copy link
Collaborator Author

piranna commented Jun 21, 2018

Currently I was doing some clean-ups and code updates, like using object destructuring or removing req.log, since I think doesn't make sense in a middleware like this.

@vvo
Copy link
Owner

vvo commented Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants