-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to log response
body & code clean-up
#5
base: master
Are you sure you want to change the base?
Conversation
Hi @piranna I am no more using nor maintaining this library, would you like to be the new maintainer? |
Also the build is broken |
That's ok for me, so far I can be able to upload new versions to npm :-) |
What's your npm username so I can add you? |
|
You now have access to both GitHub and npm publish, only ensure to make the tests pass (I am all in to switch to whatever testing system you prefer like jest), maybe deprecate some old nodejs versions and let's go. If you have no time for that, let me know too. Thanks! |
I'm a little bit bussy at this moment specially because my laptop got broken yesterday, but we can start by discussing this aspects :-) Yes, I think Jest is a good option, and to prevent pitfalls, I would configure TravisCI, coveralls and Greenkeeper too, what do you think? |
Well it's super good yep. Then prettier, eslint are also great ways to make this project even more future proof. Along with instructions on how to release it so anyone can contribute to it. I like lerna and standard-version for those kind of automation. About greenkeeper, I am myself using renovate but if you are a greenkeeper go for it! |
@piranna let me know when you want a review, right now only missing part is README I believe, and maybe some linting/prettier installation |
I don't like lerna, and for this project would not be needed. Don't know of standard-version, can you point me to it?
Interesting, do you have a link for renovate?
You can take a look if you want. The last part about the |
Currently I was doing some clean-ups and code updates, like using object destructuring or removing |
renovate: https://github.com/apps/renovate |
No description provided.