Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter updates and fixes #457

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Linter updates and fixes #457

merged 3 commits into from
Jun 11, 2024

Conversation

optik-aper
Copy link
Member

@optik-aper optik-aper commented Jun 11, 2024

Description

  • Update lint configuration
  • Fix long lines
  • Fix magic number

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@optik-aper optik-aper added the automation Build/release workflow related label Jun 11, 2024
@optik-aper optik-aper self-assigned this Jun 11, 2024
Copy link

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @optik-aper, Action: pull_request_target

@optik-aper
Copy link
Member Author

Linter fails because of change in golanci-lint version and the action is using the old version.

@optik-aper optik-aper merged commit 9628bae into vultr:master Jun 11, 2024
3 of 4 checks passed
This was referenced Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Build/release workflow related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant