Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mistyped persistent_pxe baremetal flag #432

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

jasites
Copy link
Contributor

@jasites jasites commented Mar 15, 2024

Description

before:

$ vultr-cli bare-metal create -r ewr -p vbm-24c-256gb-amd --os=1743
Error: error parsing flags for bare metal create : error parsing persistenterrpxe flag for bare metal create : flag accessed but not defined: persistenterrpxe

after:

$ ./builds/vultr-cli_linux_amd64 bare-metal create -r ewr -p vbm-24c-256gb-amd --os=1743
Error: error with bare metal create : {"error":"Server add failed: This plan is currently unavailable in this region. Please choose a different plan.","status":400}

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@jasites jasites requested a review from optik-aper March 15, 2024 18:10
Copy link

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @jasites, Action: pull_request_target

Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@optik-aper optik-aper added bug Something isn't working regression Something that worked doesn't work after changes labels Mar 15, 2024
@optik-aper optik-aper merged commit 74ce61b into vultr:master Mar 15, 2024
4 checks passed
@jasites jasites deleted the bm_persistent_pxe_flag branch March 15, 2024 19:19
@optik-aper optik-aper mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Something that worked doesn't work after changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants