Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make command Run error return consistent #419

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

optik-aper
Copy link
Member

@optik-aper optik-aper commented Mar 4, 2024

Description

v3 moved errors within the cobra commands so that error display and all of that would be consistent where possible. Some commands were still using the printer or fmt to output errors so this PR brings the stragglers up to spec.

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@optik-aper optik-aper added the enhancement New feature or request label Mar 4, 2024
@optik-aper optik-aper self-assigned this Mar 4, 2024
Copy link

github-actions bot commented Mar 4, 2024

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @optik-aper, Action: pull_request_target

Copy link

github-actions bot commented Mar 4, 2024

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @optik-aper, Action: pull_request_target

Copy link

github-actions bot commented Mar 4, 2024

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @optik-aper, Action: pull_request_target

Copy link

github-actions bot commented Mar 4, 2024

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @optik-aper, Action: pull_request_target

@optik-aper optik-aper requested a review from mondragonfx March 5, 2024 15:18
Copy link
Contributor

@mondragonfx mondragonfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested and working.

@optik-aper optik-aper merged commit 5d25961 into vultr:master Mar 5, 2024
4 checks passed
@optik-aper optik-aper mentioned this pull request Mar 12, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants