Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IP type, source and subnet size to firewall rule printer #234

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Add IP type, source and subnet size to firewall rule printer #234

merged 1 commit into from
Feb 4, 2022

Conversation

afady
Copy link
Contributor

@afady afady commented Feb 4, 2022

Description

This PR adds IP type, source and subnet size to the firewall rule printer

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@afady afady requested a review from mamclaughlin February 4, 2022 18:51
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

Unit Tests and Coverage

Show Output 
?   	github.com/vultr/vultr-cli/v2	[no test files]

Pusher: @afady, Action: pull_request_target

@ddymko ddymko added the enhancement New feature or request label Feb 4, 2022
ddymko
ddymko approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@ddymko ddymko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested - looks good

@ddymko ddymko merged commit 3484f23 into vultr:master Feb 4, 2022
@mamclaughlin mamclaughlin mentioned this pull request Feb 7, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddymko ddymko ddymko approved these changes

@mamclaughlin mamclaughlin Awaiting requested review from mamclaughlin

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afady @ddymko