-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run tests on master #201
run tests on master #201
Conversation
Unit Tests and CoverageShow Output
Pusher: @mamclaughlin, Action: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will always fail on push requests due to the "Add Comment" step. I believe this would probably be best if we split it up into 2 different jobs and set the output of "Transform Output" as a global variable and then set an IF statement for the next job to evaluate if github.event_name != 'push'
A similar implementation of the global variable can be seen here:
govultr/.github/workflows/releaser.yml
Line 14 in e9b9abd
outputs: |
and using it:
govultr/.github/workflows/releaser.yml
Line 26 in e9b9abd
if: needs.check-commit.outputs.msg_check == 'true' |
This should work:
|
Unit Tests and CoverageShow Output
Pusher: @mamclaughlin, Action: |
Unit Tests and CoverageShow Output
Pusher: @mamclaughlin, Action: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
updates when coverage test is run
Related Issues
Checklist: