-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix examples on nvidia linux #955
Conversation
As mentioned in #627 this issue is caused by this unresolved bug in nvidia drivers (apparently windows as well as linux) https://vulkan.lunarg.com/app/issues/56ca3a477ef24d0001787448 |
@rukai just as a heads up that driver bug seems to be closed. The validation message definitely sounds like it's not a bug but just wrong usage in our case?
|
oh, good to know, we'd better figure out whats going wrong then. |
I don't have enough knowledge on how vulkano handles the GPU futures. However I did give a try to using some raw functions and using fences instead of the Although probably not the most optimal fix as I'm waiting before doing the submit and present and then also immediately waiting after. |
Motion to close; expiration date seems lapsed (the examples run on Nvidia hardware) I do suspect we are missing a lot of behavior on synchronization given the validation, but mainly I'm just having difficulty getting Intel chips to run like Nvidia ones right now. |
I know at least the image example still has the issue haven't tested the others. It is probably a good idea to resolve this pull request or open another one to allow the examples to run on nvidia cards. |
closed in favor of #1246 |
The examples currently crash almost immediately on nvidia linux.
This is due to an OutOfHostMemory error as described in this issue: #923, #627
This PR changes the examples to wait on the previous frame before submitting the next frame.
I think this is the best solution but other solutions I thought of are:
Box<GpuFuture>
variable (dont need theOption<Arc<vulkano::sync::FenceSignalFuture<_>>>
)Box<GpuFuture>
variable