Task graph [7/10]: descriptor sets

[marc0246]

Follow up to #2627, adding a bindless system to the task graph.

At some point we should add a bindful system as well, as this here requires features and/or extensions. That said, the bindless system is trying to use the least amout of required features and/or extensions while still being maximally performant. It is tenchnically possible to do bindless only using core Vulkan 1.0, but it's not as performant as it could be because we wouldn't be allowed to use UPDATE_UNUSED_WHILE_PENDING, meaning we would have to create a new (huge) global descriptor set for each update, or PARTIALLY_BOUND, meaning we would have to fill the gaps with fallback resources. Alas, the only platform still not supporting bindless is Android. God forbid vendors ship up-to-date drivers.

[Rua]

The raytracing example hangs on my system when I run it. No window or other output, it just prints the device name and then sits there.

[marc0246]

You get no validation errors either?

[Rua]

No validation or syncval errors.

[marc0246]

Not even with GPU-assisted validation?

[Rua]

Nope. If I enable warnings (alongside errors) I get this, but I don't know how relevant that is:

VALIDATION-SETTINGS(WARN / SPEC): msgNum: 2132353751 - Validation Warning: [ VALIDATION-SETTINGS ] | MessageID = 0x7f1922d7 | Both GPU Assisted Validation and Normal Core Check Validation are enabled, this is not recommend as it will be very slow. Once all errors in Core Check are solved, please disable, then only use GPU-AV for best performance.
WARNING-GPU-Assisted-Validation(WARN / SPEC): msgNum: 615892639 - Validation Warning: [ WARNING-GPU-Assisted-Validation ] Object 0: handle = 0x55f1c598b910, type = VK_OBJECT_TYPE_PHYSICAL_DEVICE; | MessageID = 0x24b5c69f | vkGetPhysicalDeviceProperties2(): Internal Warning: Setting VkPhysicalDeviceVulkan12Properties::maxUpdateAfterBindDescriptorsInAllPools to 32
Objects: 1
[0] 0x55f1c598b910, type: 2, name: NULL
WARNING-GPU-Assisted-Validation(WARN / SPEC): msgNum: 615892639 - Validation Warning: [ WARNING-GPU-Assisted-Validation ] Object 0: handle = 0x55f1c5a32aa0, type = VK_OBJECT_TYPE_PHYSICAL_DEVICE; | MessageID = 0x24b5c69f | vkGetPhysicalDeviceProperties2(): Internal Warning: Setting VkPhysicalDeviceVulkan12Properties::maxUpdateAfterBindDescriptorsInAllPools to 32
Objects: 1
[0] 0x55f1c5a32aa0, type: 2, name: NULL
WARNING-GPU-Assisted-Validation(WARN / SPEC): msgNum: 615892639 - Validation Warning: [ WARNING-GPU-Assisted-Validation ] Object 0: handle = 0x55f1c5a21d00, type = VK_OBJECT_TYPE_PHYSICAL_DEVICE; | MessageID = 0x24b5c69f | vkGetPhysicalDeviceProperties2(): Internal Warning: Setting VkPhysicalDeviceVulkan12Properties::maxUpdateAfterBindDescriptorsInAllPools to 32
Objects: 1
[0] 0x55f1c5a21d00, type: 2, name: NULL
Using device: AMD Radeon RX 7600 (RADV NAVI33) (type: DiscreteGpu)
WARNING-GPU-Assisted-Validation(WARN / SPEC): msgNum: 615892639 - Validation Warning: [ WARNING-GPU-Assisted-Validation ] | MessageID = 0x24b5c69f | vkCreateDevice(): Internal Warning: Forcing fragmentStoresAndAtomics to VK_TRUE
WARNING-GPU-Assisted-Validation(WARN / SPEC): msgNum: 615892639 - Validation Warning: [ WARNING-GPU-Assisted-Validation ] | MessageID = 0x24b5c69f | vkCreateDevice(): Internal Warning: Forcing vertexPipelineStoresAndAtomics to VK_TRUE

[marc0246]

It's probably something super stupid like waiting on a fence that was never going to be signalled.

[marc0246]

It would be really helpful if you figured out where it hangs.

[Rua]

It appears to be freezing in Resources::new during the initialization, line 143.

[marc0246]

Does it work now?

[Rua]

No, still the same.

[marc0246]

Can you tell me exactly where it hangs? Like if you follow the call stack all the way.