Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert making Raw{Buffer,Image}::bind_memory unsafe #2595

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

marc0246
Copy link
Contributor

This reverts the making unsafe of the bind_memory methods that was done in #2413, as it's a bit silly to make code that was safe before unsafe because of a niche use case which already comes with unsafe code.

Changelog:
Remove these lines:

### Breaking changes
Changes to buffers:
- `RawBuffer::bind_memory` is now marked unsafe.

Changes to images:
- `RawImage::bind_memory` is now marked unsafe.

@Rua Rua merged commit a44a778 into vulkano-rs:master Oct 30, 2024
6 checks passed
Rua added a commit that referenced this pull request Oct 30, 2024
@marc0246 marc0246 deleted the bind-memory branch October 30, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants