This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Increase logging in contract watcher #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmulhol
requested review from
m0ar,
yaoandrew,
elizabethengelman,
Gslaughl and
i-norden
i-norden
approved these changes
Sep 26, 2019
| tr.Poller.FetchContractData(tr.Parser.Abi(), contractAddr, "name", nil, name, tr.LastBlock) | ||
| pollingErr := tr.Poller.FetchContractData(tr.Parser.Abi(), contractAddr, "name", nil, name, tr.LastBlock) | ||
| if pollingErr != nil { | ||
| // can't return this error because "name" might not exist on the contract |
elizabethengelman
approved these changes
Oct 2, 2019
🚀| headerRepository.CreateOrUpdateHeader(mocks.MockHeader2) | ||
| headerRepository.CreateOrUpdateHeader(mocks.MockHeader3) | ||
| _, err := headerRepository.CreateOrUpdateHeader(mocks.MockHeader1) | ||
| Expect(err).ToNot(HaveOccurred()) |
| addresses, err = r.RetrieveTokenHolderAddresses(*info) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
| var retrieveErr error | ||
| addresses, retrieveErr = r.RetrieveTokenHolderAddresses(*info) |
There was a problem hiding this comment.
super tiny, but I think we could probably change this to addresses, retrieveErr := r.RetrieveTokenHolderAddresses(*info) instead of defining retrieveErr on the line above.
| addresses, err = r.RetrieveTokenHolderAddresses(contract.Contract{}) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
| var retrieveErr error | ||
| addresses, retrieveErr = r.RetrieveTokenHolderAddresses(contract.Contract{}) |
There was a problem hiding this comment.
here too, totally not merge blocking.
rmulhol
force-pushed
the
contract-watcher-logging
branch
from
ab81192 to
8a93cfb
Compare
- Focus on header mode - Add context to errors, trace guard clauses, warn on non-returned errors - Give errors distinct names so compiler will recognize if unchecked - Remove redundant type declarations/fix typos
rmulhol
force-pushed
the
contract-watcher-logging
branch
from
8a93cfb to
4505382
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errors