Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add record tab for displaying channels. #4165

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

demiankatz
Copy link
Member

@demiankatz demiankatz commented Dec 16, 2024

This PR creates a tab to embed channels on the record page. It is configured to be disabled by default; uncomment the relevant line(s) in RecordTabs.ini to try it out.

This also adds a missing translation: the text "Channels" is already used in breadcrumbs but was missing from language files.

The ChannelLoader code has also been simplified to take advantage of constructor property promotion.

TODO:

  • Discuss: do we need a way to configure different channels in the tab vs. the normal "record channels" context?
  • Add test coverage
  • Discuss: should we deprecate the "similar items" tab in favor of the richer channels tab? We could create a default configuration of the Channels tab that behaves almost exactly like similar items in order to take its place. (This might make the most sense as a follow-up action after merging this PR).

@demiankatz demiankatz added this to the 11.0 milestone Dec 16, 2024
@demiankatz demiankatz added the new language strings adds new text in need of translation label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature new language strings adds new text in need of translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant