Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace getSavedData() with getFavoritesForRecord(). #3751

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Replace getSavedData() with getFavoritesForRecord(). #3751

merged 3 commits into from
Jun 6, 2024

Conversation

demiankatz
Copy link
Member

This backports and adapts the work from demiankatz#28 -- the remaining work from there will be incorporated into #2233 when this is merged.

@demiankatz demiankatz added this to the 10.0 milestone Jun 5, 2024
@demiankatz demiankatz added the architecture pull requests that involve significant refactoring / architectural changes label Jun 5, 2024
@demiankatz demiankatz requested review from EreMaijala and aleksip June 5, 2024 22:55
@demiankatz demiankatz removed the request for review from EreMaijala June 6, 2024 12:28
@demiankatz
Copy link
Member Author

Thanks, @aleksip! I've addressed your feedback in commit 2fb2620, and tests are still passing, so I'm merging now.

@demiankatz demiankatz merged commit 235cc5e into vufind-org:dev Jun 6, 2024
7 checks passed
@demiankatz demiankatz deleted the refactor-getsaveddata branch June 6, 2024 14:07
@demiankatz demiankatz mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksip aleksip aleksip approved these changes

Assignees
No one assigned
Labels
architecture pull requests that involve significant refactoring / architectural changes
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@demiankatz @aleksip