Allow nullish coalescing operator (??) in Javascript #3682
Conversation
There was a problem hiding this comment.
Worth noting that this change will allow a lot more than just the nullish coalescing operator.
I'm slightly worried that this will exclude a significant number of older devices that cannot be updated (e.g. iPads) that, while obviously outdated and probably not very safe, are otherwise still usable. I'm not saying this change shouldn't be made, but dropping the support for pre-2020 devices should be a conscious decision.
I'm saying this because we had a significant number of problem reports when we enabled cookie consent with a library version that required support for the optional chaining operator. It's been a while since, so the situation might be different.
.eslintrc.js
Outdated
| @@ -10,6 +10,9 @@ module.exports = { | |||
| "es6": true, | |||
| "jquery": true | |||
| }, | |||
| parserOptions: { | |||
| "ecmaVersion": "latest" | |||
There was a problem hiding this comment.
I know this doesn't actually change anything since latest has been the default, but should we actually use something like 2020 to align with esversion with jshint?
There was a problem hiding this comment.
Yes, I think that makes sense. Changed it.
|
I understand your concern. So, I would not mind waiting with this change a bit longer. The nullish coalescing operator would work really well for adding default values to the new js configs. But we also could add default values with an additional parameter for the You and @demiankatz have more experience and know the user base better than me so I trust your judgement. |
|
I wouldn't want to change device support without a bit of a heads up. So we could sync this with a future release like 10.1 or 11. |
|
I'm putting the milestone on this at 11.0, since this feels like a "major version" change, and I don't think we have enough time to thoroughly finish this conversation in time for release 10.0. We do have a browser support statement, so I think we'd have to update that if we merged this. The question is whether we want to have a more specific policy going forward (e.g. "last five years of hardware") to help make these kinds of decisions easier. Probably worth a future Community Call discussion, which we should have time for over the summer, after the push for release 10.0 is over. |
|
I'm still a bit torn on this. Allowing ES 2020 would definitely rule out support for Safari pre Sep 16 2020 (some features would require versions from 2021, but unlikely to be used in VuFind yet). Not sure if we are there yet. |
|
Since the purpose of this PR was only to allow a bit more syntactic sugar, I also don't see that this really justifies dropping the support for older devices. |
|
@ThoWagen and @EreMaijala, would you like me to make a 12.0 milestone, and we can bump this another year down the road for reconsideration later? |
|
@demiankatz I think that'd make sense! |
|
Done! |
|
I've created a dev-12.0 branch and targeted this there, just to be sure we don't accidentally merge this to the wrong place prematurely. I don't think we should merge it until closer to the start of 12.0 development, but at least this way, if the merge button gets hit by accident, it won't mess us up! :-) |
This PR changes the eslint and jshint configuration so that the nullish coalescing operator (??) is allowed in Javascript.