Add complete unit tests for EDS driver #3302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
requested changes
Jan 9, 2024
There was a problem hiding this comment.
Thanks, @meganschanz, this is great work and much appreciated -- always good to improve our coverage. Just a few (mostly trivial) comments and questions.
module/VuFind/tests/unit-tests/src/VuFindTest/RecordDriver/EDSTest.php
Outdated
Show resolved
Hide resolved
module/VuFind/tests/unit-tests/src/VuFindTest/RecordDriver/EDSTest.php
Outdated
Show resolved
Hide resolved
module/VuFind/tests/unit-tests/src/VuFindTest/RecordDriver/EDSTest.php
Outdated
Show resolved
Hide resolved
module/VuFind/tests/unit-tests/src/VuFindTest/RecordDriver/EDSTest.php
Outdated
Show resolved
Hide resolved
module/VuFind/tests/unit-tests/src/VuFindTest/RecordDriver/EDSTest.php
Outdated
Show resolved
Hide resolved
…l EDS function to detail out return values
demiankatz
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Looks great! Thanks for the updates, @meganschanz -- merging now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired from last week's work on writing a few more unit tests for the EDS driver, I decided to write the rest to get it up to 100% coverage. I did end up refactoring it slightly to move the expected results into fixtures to avoid the test file from getting too busy. But otherwise, hopefully this is pretty straight forward since it's just adding tests and not touching any functionality.
As always, let me know if anyone has suggestions for improvements!