Trivial: more semantic assertions in test.

vufind-org · Feb 4, 2025 · 4c377c7 · 4c377c7
1 parent 429c14f
commit 4c377c7
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/module/VuFind/tests/unit-tests/src/VuFindTest/View/Helper/Root/GoogleTagManagerTest.php b/module/VuFind/tests/unit-tests/src/VuFindTest/View/Helper/Root/GoogleTagManagerTest.php
@@ -52,8 +52,8 @@ class GoogleTagManagerTest extends \PHPUnit\Framework\TestCase
     public function testHeadCode(): void
     {
         $output = $this->renderGTMHeadCode('fakeContainerId');
-        $this->assertTrue(false !== strstr($output, 'gtm.js'));
-        $this->assertTrue(false !== strstr($output, 'fakeContainerId'));
+        $this->assertStringContainsString('gtm.js', $output);
+        $this->assertStringContainsString('fakeContainerId', $output);
     }
 
     /**
@@ -64,8 +64,8 @@ public function testHeadCode(): void
     public function testBodyCode(): void
     {
         $output = $this->renderGTMBodyCode('fakeContainerId');
-        $this->assertTrue(false !== strstr($output, 'ns.html'));
-        $this->assertTrue(false !== strstr($output, 'fakeContainerId'));
+        $this->assertStringContainsString('ns.html', $output);
+        $this->assertStringContainsString('fakeContainerId', $output);
     }
 
     /**