Skip to content

Commit

Permalink
Improve Mink FeedbackTest (#2849)
Browse files Browse the repository at this point in the history
- Use 0 as captcha interval to ensure that the test passes without retries. This fixes intermittent retries from the interval captcha Mink test.
- Also remove a stray comment.
  • Loading branch information
EreMaijala authored Apr 21, 2023
1 parent de48978 commit 083f0ba
Showing 1 changed file with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ protected function fillInAndSubmitFeedbackForm($page)
*/
public function testFeedbackForm()
{
// By default, no OpenURL on record page:
$page = $this->setupPage();
$this->fillInAndSubmitFeedbackForm($page);
$this->assertEquals(
Expand Down Expand Up @@ -168,13 +167,13 @@ public function testIntervalCaptcha()
$this->findCss($page, '#modal .alert-danger')->getText(),
);

// Set up with minimal delay and test that submission is passed:
// Set up with no real delay and test that submission is passed:
$page = $this->setupPage(
[
'Captcha' => [
'types' => ['interval'],
'forms' => 'feedback',
'action_interval' => 1,
'action_interval' => 0,
],
]
);
Expand Down

0 comments on commit 083f0ba

Please sign in to comment.