Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(usePermission): state setting #4167

Merged
merged 1 commit into from
Aug 24, 2024
Merged

fix(usePermission): state setting #4167

merged 1 commit into from
Aug 24, 2024

Conversation

ferferga
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

As discussed in #4149 (starting from this comment), the way the state is setted in this composable is not ideal:

  • If the composable failed, the state is setted as prompt, but it won't be queried again, since permissionStatus is not set to undefined. Another solution would be to remove the if from the query (I'm not sure if it's strictly necessary there).
  • If permissionStatus is undefined, previously we did nothing, now we set it to 'prompt'. All of this has been refactored into an update function and simplified with the use of the finally statement.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 21, 2024
@ferferga ferferga mentioned this pull request Aug 21, 2024
7 tasks
@antfu antfu changed the title refactor(usePermission): state setting fix(usePermission): state setting Aug 21, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants