add guard for selection setting

closes slab#1940
vueup · Jul 10, 2018 · 9a65a80 · 9a65a80
1 parent 9026999
commit 9a65a80
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/core/selection.js b/core/selection.js
@@ -38,12 +38,17 @@ class Selection {
       if (native.start.node === this.cursor.textNode) return; // cursor.restore() will handle
       this.emitter.once(Emitter.events.SCROLL_UPDATE, () => {
         try {
-          this.setNativeRange(
-            native.start.node,
-            native.start.offset,
-            native.end.node,
-            native.end.offset,
-          );
+          if (
+            this.root.contains(native.start.node) &&
+            this.root.contains(native.end.node)
+          ) {
+            this.setNativeRange(
+              native.start.node,
+              native.start.offset,
+              native.end.node,
+              native.end.offset,
+            );
+          }
           this.update(Emitter.sources.SILENT);
         } catch (ignored) {
           // ignore