refactor: ripple should more closely resemble MD spec #5059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated ripple effect to hopefully more closely resemble material design ripple.
I was unable to find a good single solution for both rectangular and circular ripples, so I've added a
circle
option to the ripple directive. Someone smarter than me might have a better solution?Motivation and Context
because (also fixes #5021)
How Has This Been Tested?
with provided markup
Markup:
Types of changes
Checklist:
master
for bug fixes,dev
for new features and breaking changes).