Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VSwitch): add loading prop #4805

Merged
merged 2 commits into from
Oct 9, 2018
Merged

feat(VSwitch): add loading prop #4805

merged 2 commits into from
Oct 9, 2018

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Aug 6, 2018

Motivation and Context

https://storage.googleapis.com/spec-host-backup/mio-design%2Fassets%2F13vdLWUJ-zpgHVaYc2Mwddd5oY9ElA-Uq%2Fslidercontrols-1b-v02.mp4

How Has This Been Tested?

Markup:

<template>
  <v-app>
    <v-container>
      <v-switch v-model="loading" label="loading"></v-switch>
      <v-switch :loading="loading"></v-switch>
      <v-switch :loading="loading" color="green"></v-switch>
      <v-switch :loading="loading && 'green'" :color="loading ? 'white' : 'green'"></v-switch>
      <v-text-field :loading="loading"></v-text-field>
      <v-slider :loading="loading"></v-slider>
    </v-container>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
      loading: false
    })
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@KaelWD KaelWD added the T: feature A new feature label Aug 6, 2018
@KaelWD KaelWD added this to the v1.3.0 milestone Aug 6, 2018
@KaelWD KaelWD self-assigned this Aug 6, 2018
@codecov
Copy link

codecov bot commented Aug 6, 2018

Codecov Report

Merging #4805 into dev will decrease coverage by 0.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4805      +/-   ##
==========================================
- Coverage   89.41%   88.84%   -0.57%     
==========================================
  Files         244      231      -13     
  Lines        5770     5443     -327     
  Branches     1438     1394      -44     
==========================================
- Hits         5159     4836     -323     
+ Misses        486      483       -3     
+ Partials      125      124       -1
Impacted Files Coverage Δ
src/components/VInput/VInput.js 93.84% <ø> (-0.1%) ⬇️
src/components/VSlider/VSlider.js 99.33% <100%> (ø) ⬆️
src/components/VTextField/VTextField.js 94.11% <100%> (+0.04%) ⬆️
src/components/VSwitch/VSwitch.js 88.23% <100%> (+2.52%) ⬆️
src/components/VBtnToggle/VBtnToggle.ts 80.55% <0%> (-19.45%) ⬇️
src/mixins/button-group.ts 85.18% <0%> (-14.82%) ⬇️
src/components/VMenu/mixins/menu-keyable.js 86.36% <0%> (-4.55%) ⬇️
src/components/VBottomNav/VBottomNav.ts 88.88% <0%> (-4.45%) ⬇️
.../components/VNavigationDrawer/VNavigationDrawer.js 67.03% <0%> (-1.1%) ⬇️
src/mixins/applicationable.ts 90% <0%> (-0.48%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c328698...c6a63f5. Read the comment docs.

@jacekkarczmarczyk jacekkarczmarczyk added the S: has merge conflicts The pending Pull Request has merge conflicts label Aug 14, 2018
@KaelWD KaelWD force-pushed the dev branch 2 times, most recently from 590b80c to 214e561 Compare August 14, 2018 16:10
@KaelWD KaelWD removed the S: has merge conflicts The pending Pull Request has merge conflicts label Sep 2, 2018
@johnleider johnleider merged commit 91ad55b into dev Oct 9, 2018
@johnleider johnleider deleted the feat/switch-progress branch October 9, 2018 16:09
johnleider added a commit that referenced this pull request Oct 17, 2018
@lock
Copy link

lock bot commented Apr 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants