Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VSelectionControl): label opacity matching regular text #20738

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

J-Sek
Copy link
Contributor

@J-Sek J-Sek commented Nov 26, 2024

Description

fixes #18804

  • Q: do we need it for v-checkbox-btn as well? I cannot imagine anyone using it with label prop, but it is available nevertheless.

Markup:

<template>
  <v-app theme="dark">
    <v-container>

      <v-checkbox hide-details label="Checkbox"></v-checkbox>
      <v-checkbox hide-details disabled label="Checkbox disabled"></v-checkbox>
      <v-checkbox hide-details :model-value='true' label="Checkbox selected"></v-checkbox>

      <v-switch hide-details label="Checkbox"></v-switch>
      <v-switch hide-details disabled label="Checkbox disabled"></v-switch>
      <v-switch hide-details :model-value='true' label="Checkbox selected"></v-switch>

      <v-radio label="Radio button"></v-radio>
      <v-radio disabled label="Radio button disabled"></v-radio>
      <v-radio :model-value='true' label="Radio button selected"></v-radio>

    </v-container>
  </v-app>
</template>

@J-Sek J-Sek self-assigned this Nov 26, 2024
@KaelWD
Copy link
Member

KaelWD commented Dec 9, 2024

There's also VRadio. I would probably set this in VSelectionControl and remove the redundant error/disabled override

&--error,
&--disabled
.v-label
opacity: 1

@KaelWD KaelWD changed the title fix(VCheckbox, VSwitch): label opacity matching regular text fix(VSelectionControl): label opacity matching regular text Dec 11, 2024
@KaelWD KaelWD merged commit f804c50 into vuetifyjs:master Dec 11, 2024
4 of 5 checks passed
@J-Sek J-Sek deleted the fix/18804 branch December 18, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.4.4] Checkbox label text is greyed out, which doesn't match the Material Design specification
2 participants