fix(a11y): add aria-current="page" attribute to links
#20413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-thebaud
force-pushed
the
fix/20399-aria-current-anchor
branch
from
daae92a to
b1b3285
Compare
paul-thebaud
force-pushed
the
fix/20399-aria-current-anchor
branch
from
b1b3285 to
c2a991e
Compare
paul-thebaud
commented
Sep 3, 2024
| href, | ||
| linkProps: reactive({ | ||
| href, | ||
| ariaCurrent: computed(() => isActive.value ? 'page' : undefined), |
There was a problem hiding this comment.
aria-current should use kebab case name, because vue 3 won't concert it automatically.
There was a problem hiding this comment.
Looks like it depends on the attribute, HTMLElement.ariaCurrent exists so it works but others might not: vuejs/core#5477
There was a problem hiding this comment.
Chrome automatically converts attributes, but Firefox doesn't. There is an open issue about it on vuetify and vue repos.
KaelWD
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an
aria-current="page"attribute to VBtn, VCard, VChip, VListItem and VBreadcrumbsItem when active value from router istrue.closes #20399