Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] VCalendar - [Vue warn]: Failed to resolve directive: ripple #8096

Closed
Apther opened this issue Jul 27, 2019 · 4 comments · Fixed by #8189
Closed

[Bug Report] VCalendar - [Vue warn]: Failed to resolve directive: ripple #8096

Apther opened this issue Jul 27, 2019 · 4 comments · Fixed by #8189
Assignees
Labels
C: VCalendar T: bug Functionality that does not work as intended/expected

Comments

@Apther
Copy link

Apther commented Jul 27, 2019

Environment

Vuetify Version: 2.0.1
Vue Version: 2.6.10
Browsers: Google Chrome, Mozilla Firefox
OS: Windows 10, Windows

Steps to reproduce

  1. Add calendar with event (use the provided git with example from docs)
  2. Check console

Expected Behavior

No warning

Actual Behavior

Console:

[Vue warn]: Failed to resolve directive: ripple
(found in )

Reproduction Link

https://github.com/Apther/vuetify-calendar-ripple-bug.git

Other comments

Probably missing import in vuetify/lib/components/VCalendar/mixins/calendar-with-events.js :

import ripple from '../../../directives/ripple'

and directive in CalendarBase.extend:

directives: {
    ripple
}

But I'm not sure if it's correct solution.

Another way to solve it was importing vuetify from vuetify (not vuetify/lib), but since version 2.0.1 it destroys some styles, so it's not usable.

@ghost ghost added the S: triage label Jul 27, 2019
@KluseG
Copy link

KluseG commented Jul 29, 2019

Same in v2.0.2, no ripple effect on event "bar" and [Vue varn] in console

@ClickerMonkey
Copy link
Contributor

Thanks for the issue, creating a PR to fix this soon.

ClickerMonkey added a commit that referenced this issue Jul 30, 2019
johnleider pushed a commit that referenced this issue Aug 1, 2019
* fix(VCalendar): end date and ripple errors

fixes #8096
fixes #8175

* fix(VCalendar): fixed test snapshot for first day of month
@jild
Copy link

jild commented Oct 19, 2020

I get the same warning when using with Code example from https://vuetifyjs.com/en/components/data-tables/#crud-actions

And using a custom slot with a checkbox:

<v-data-table ...>

    <template v-slot:item.linked="{ item }">
      <v-simple-checkbox
          v-model="item.linked"
      ></v-simple-checkbox>
    </template>
</v-data-table>

If the checkbox is disabled everything works perfectly.
Otherwise I get:

[Vue warn]: Failed to resolve directive: ripple

@johnleider
Copy link
Member

We kindly ask users to not comment on closed/resolved issues. If you believe that this issue has not been correctly resolved, please create a new issue showing the regression.

If you have any additional questions, please reach out to us in our Discord community.

@vuetifyjs vuetifyjs locked as resolved and limited conversation to collaborators Nov 5, 2020
@johnleider johnleider added C: VCalendar T: bug Functionality that does not work as intended/expected and removed S: triage labels Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VCalendar T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants