Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Disabled v-select chip with dark mode #5074

Closed
mrmattrc opened this issue Sep 11, 2018 · 0 comments
Closed

[Bug Report] Disabled v-select chip with dark mode #5074

mrmattrc opened this issue Sep 11, 2018 · 0 comments
Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected

Comments

@mrmattrc
Copy link

mrmattrc commented Sep 11, 2018

Versions and Environment

Vuetify: 1.2.3
Vue: 2.5.16
Browsers: Chrome
OS: macOS Mojave

Steps to reproduce

Create a v-select that is disabled, uses chips, and is on dark mode.

Expected Behavior

The text color should not appear as white within a white chip. I feel like the expected behavior for a dark mode chip is that the chip itself should show up dark with some lighter text. Furthermore, the only change necessary if the v-select is disabled is to change the text color (perhaps the same color as the disabled color for a non-dark chip).

Actual Behavior

The text color is showing up as white.

Reproduction Link

https://codepen.io/MAXXtreme/pen/LJdNya

Additional Comments

It appears that adding a simple class fixes the issue. Thank you @jacekkarczmarczyk for pointing that out.
https://codepen.io/MAXXtreme/pen/pOLyGV

@nekosaur nekosaur added the T: bug Functionality that does not work as intended/expected label Sep 14, 2018
jacekkarczmarczyk added a commit that referenced this issue Oct 26, 2018
@johnleider johnleider added S: has PR The issue has a pending Pull Request and removed S: work in progress labels Oct 26, 2018
jacekkarczmarczyk added a commit that referenced this issue Oct 29, 2018
SeanLMcCullough pushed a commit to SeanLMcCullough/vuetify that referenced this issue Nov 29, 2018
@MajesticPotatoe MajesticPotatoe changed the title Disabled v-select chip with dark mode [Bug Report] Disabled v-select chip with dark mode Dec 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

3 participants