Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Fixed the code to display the unique images and media_gallery on the product page(#404) #490

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ymaheshwari1
Copy link

Related Issues

#404

closes #404

Short Description of the PR

When changing the value of mergeConfigurableChildren to false the product gallery is not displayed as it should.
Using the uniqBy method to display only the unique images in the gallery and also added the media_gallery in the gallery to display all the images in the product gallery.

Screenshots of Visual Changes before/after (if There Are Any)

Pull Request Checklist

  • I have updated the Changelog (V1) and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

Contribution and Currently Important Rules Acceptance

Copy link

@Fifciu Fifciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Please resolve the conflict

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants