Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: action typings #262

Merged
merged 2 commits into from
Oct 12, 2018
Merged

fix: action typings #262

merged 2 commits into from
Oct 12, 2018

Conversation

xMartin
Copy link
Contributor

@xMartin xMartin commented Oct 12, 2018

The ActionContext type takes two types as arguments: the module state
and the root state. In the counter example module we passed the state
twice instead which still works as we are not using the root state.

What is accomplished by your PR?

Fix typings for actions to prevent running into typing issues as soon as you are using the root state.

Is there something controversial in your PR?

Not if I got it right.

Checklist

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing
  • Add new passing unit tests to cover the code introduced by your PR
  • Add new documentation for the code introduced by your PR

The ActionContext type takes two types as arguments: the module state
and the root state. In the counter example module we passed the state
twice instead which still works as we are not using the root state.
@xMartin xMartin requested a review from devCrossNet October 12, 2018 21:40
@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #262 into next will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           next   #262   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        64     64           
  Lines      1264   1264           
  Branches    171    171           
===================================
  Hits       1264   1264
Impacted Files Coverage Δ
src/app/counter/actions.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e6dfc2...b4426e5. Read the comment docs.

@devCrossNet devCrossNet changed the base branch from master to next October 12, 2018 21:43
Copy link
Member

@devCrossNet devCrossNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devCrossNet devCrossNet added the DX label Oct 12, 2018
@devCrossNet devCrossNet added this to the 1.4.0 milestone Oct 12, 2018
@devCrossNet devCrossNet merged commit 22dcbb3 into next Oct 12, 2018
@devCrossNet devCrossNet deleted the fix/action-typings branch October 12, 2018 21:59
@xMartin xMartin mentioned this pull request Oct 22, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants