feat(components): add data-table #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #167 +/- ##
===================================
Coverage 100% 100%
===================================
Files 61 66 +5
Lines 1109 1192 +83
Branches 150 161 +11
===================================
+ Hits 1109 1192 +83
Continue to review full report at Codecov.
|
devCrossNet
commented
Jun 10, 2018
| sortKey: null, | ||
| sortDirection: 'asc', | ||
| currentPage: 0, | ||
| maxPages: 1, |
There was a problem hiding this comment.
computed prop, to remove the watcher and cache the result
devCrossNet
commented
Jun 10, 2018
| } | ||
|
|
||
| const searchRegex: RegExp = new RegExp(`${this.searchTerm}`, 'gmi'); | ||
| const filter = (columns: any[]) => { |
devCrossNet
commented
Jun 10, 2018
| return `${100 / this.columns.length}%`; | ||
| }, | ||
| rows() { | ||
| return this.displayData.map((row: any[]) => { |
40818419
reviewed
Jun 10, 2018
| data: dataTableDataFixture, | ||
| }; | ||
| }, | ||
| template: `<vueDataTable :header="header" :data="data" placeholder="Search" @click="action" />`, |
40818419
reviewed
Jun 10, 2018
| data: dataTableDataFixture, | ||
| }; | ||
| }, | ||
| template: `<vueDataTable :header="header" :data="data" :show-search="false" :page="1" :max-rows="10" @click="action" />`, |
devCrossNet
force-pushed
the
feat/data-table
branch
from
f95d0eb to
a03b854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #141
What is accomplished by your PR?
This PR adds a new DataTable component which includes following features:
Is there something controversial in your PR?
nope
Link to the Issue
#141
Checklist
New Feature / Bug Fix