refactor(components): remove required:false and default:null

vuesion · Nov 6, 2018 · d69f6f9 · d69f6f9
1 parent 1bfa8c6
commit d69f6f9
Show file tree

Hide file tree

Showing 21 changed files with 8 additions and 68 deletions.
diff --git a/package.json b/package.json
@@ -216,7 +216,7 @@
   "husky": {
     "hooks": {
       "commit-msg": "commitlint -e $HUSKY_GIT_PARAMS",
-      "pre-commit": "concurrently \"npm run lint\" \"npm run test:coverage -- --silent\""
+      "pre-commit": "concurrently \"npm run lint\" \"npm run test:coverage\""
     }
   }
 }
diff --git a/src/app/shared/animations/CollapseAnimation/CollapseAnimation.vue b/src/app/shared/animations/CollapseAnimation/CollapseAnimation.vue
@@ -17,7 +17,6 @@
     props:      {
       duration: {
         type:     Number,
-        required: false,
         default:  250,
       },
     },

diff --git a/src/app/shared/components/VueAccordion/VueAccordion.vue b/src/app/shared/components/VueAccordion/VueAccordion.vue
@@ -10,7 +10,6 @@
     props:      {
       multiple:    {
         type:     Boolean,
-        required: false,
         default:  false,
       },
     },

diff --git a/src/app/shared/components/VueAccordion/VueAccordionItem/VueAccordionItem.vue b/src/app/shared/components/VueAccordion/VueAccordionItem/VueAccordionItem.vue
@@ -34,7 +34,6 @@
       },
       initOpen: {
         type:     Boolean,
-        required: false,
         default:  false,
       },
     },

diff --git a/src/app/shared/components/VueAutocomplete/VueAutocomplete.vue b/src/app/shared/components/VueAutocomplete/VueAutocomplete.vue
@@ -71,45 +71,36 @@
       name:          {
         type:     String,
         default:  '',
-        required: false,
       },
       id:            {
         type:     String,
         default:  '',
-        required: false,
       },
       options:       {
         type:     Array,
-        required: false,
         default:  (): any[] => [],
       },
       placeholder:   {
         type:     String,
-        required: false,
       },
       maxOptions:    {
         type:     Number,
-        required: false,
         default:  5,
       },
       minInputChars: {
         type:     Number,
-        required: false,
         default:  3,
       },
       isLoading:     {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       required:      {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       disabled:      {
         type:     Boolean,
-        required: false,
         default:  false,
       },
     },

diff --git a/src/app/shared/components/VueBadge/VueBadge.vue b/src/app/shared/components/VueBadge/VueBadge.vue
@@ -10,25 +10,30 @@
     props:    {
       primary:   {
         type: Boolean,
+        default:  false,
       },
       secondary: {
         type: Boolean,
+        default:  false,
       },
       tertiary:  {
         type: Boolean,
+        default:  false,
       },
       danger:    {
         type: Boolean,
+        default:  false,
       },
       warning: {
         type: Boolean,
+        default:  false,
       },
       success:   {
         type: Boolean,
+        default:  false,
       },
       outlined:  {
         type:     Boolean,
-        required: false,
         default:  false,
       },
     },

diff --git a/src/app/shared/components/VueButton/VueButton.vue b/src/app/shared/components/VueButton/VueButton.vue
@@ -19,52 +19,42 @@
     props:      {
       primary:   {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       secondary: {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       tertiary:  {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       danger:    {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       warning:   {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       success:   {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       disabled:  {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       loading:   {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       outlined:  {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       ghost:     {
         type:     Boolean,
-        required: false,
         default:  false,
       },
     },

diff --git a/src/app/shared/components/VueCalendar/VueCalendar.vue b/src/app/shared/components/VueCalendar/VueCalendar.vue
@@ -123,33 +123,26 @@
     props:      {
       today:          {
         type:     Date,
-        required: false,
         default:  () => new Date(),
       },
       minDate:        {
         type:     Date,
-        required: false,
       },
       maxDate:        {
         type:     Date,
-        required: false,
       },
       firstDayOfWeek: {
         type:     Number,
-        required: false,
         default:  0,
       },
       startDate:      {
         type:     Date,
-        required: false,
       },
       endDate:        {
         type:     Date,
-        required: false,
       },
       selectedDate:   {
         type:     Date,
-        required: false,
       },
     },
     computed:   {

diff --git a/src/app/shared/components/VueCard/VueCardHeader/VueCardHeader.vue b/src/app/shared/components/VueCard/VueCardHeader/VueCardHeader.vue
@@ -14,17 +14,14 @@
     props:      {
       title:    {
         type:     String,
-        required: false,
         default:  '',
       },
       subtitle: {
         type:     String,
-        required: false,
         default:  '',
       },
       image:    {
         type:     String,
-        required: false,
         default:  '',
       },
     },

diff --git a/src/app/shared/components/VueCollapse/VueCollapse.vue b/src/app/shared/components/VueCollapse/VueCollapse.vue
@@ -16,11 +16,9 @@
       show:     {
         default:  true,
         type:     Boolean,
-        required: false,
       },
       duration: {
         type:     Number,
-        required: false,
         default:  250,
       },
     },

diff --git a/src/app/shared/components/VueDatePicker/VueDatePicker.vue b/src/app/shared/components/VueDatePicker/VueDatePicker.vue
@@ -49,33 +49,26 @@
       },
       minDate:        {
         type:     Date,
-        required: false,
       },
       maxDate:        {
         type:     Date,
-        required: false,
       },
       firstDayOfWeek: {
         type:     Number,
-        required: false,
         default:  0,
       },
       placeholder:    {
         type:     String,
-        required: false,
         default:  '',
       },
       startDate:      {
         type:     Date,
-        required: false,
       },
       endDate:        {
         type:     Date,
-        required: false,
       },
       currentDate:    {
         type:     Date,
-        required: false,
       },
       required:       {
         type:    Boolean,

diff --git a/src/app/shared/components/VueDateRangePicker/VueDateRangePicker.vue b/src/app/shared/components/VueDateRangePicker/VueDateRangePicker.vue
@@ -34,25 +34,20 @@
     props:      {
       minDate:          {
         type:     Date,
-        required: false,
       },
       maxDate:          {
         type:     Date,
-        required: false,
       },
       firstDayOfWeek:   {
         type:     Number,
-        required: false,
         default:  0,
       },
       placeholderStart: {
         type:     String,
-        required: false,
         default:  '',
       },
       placeholderEnd:   {
         type:     String,
-        required: false,
         default:  '',
       },
     },

diff --git a/src/app/shared/components/VueGridItem/VueGridItem.vue b/src/app/shared/components/VueGridItem/VueGridItem.vue
@@ -10,7 +10,6 @@
     props:    {
       fill:     {
         type:     Boolean,
-        required: false,
         default:  false,
       },
     },

diff --git a/src/app/shared/components/VueHeadline/VueHeadline.vue b/src/app/shared/components/VueHeadline/VueHeadline.vue
@@ -15,7 +15,6 @@
       },
       appearanceLevel: {
         type:     String,
-        required: false,
       },
       native:          {
         type:    Boolean,

diff --git a/src/app/shared/components/VueLoader/VueLoader.vue b/src/app/shared/components/VueLoader/VueLoader.vue
@@ -19,42 +19,34 @@
     props:    {
       medium:    {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       large:     {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       primary:   {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       secondary: {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       tertiary:  {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       danger:    {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       warning: {
         type:     Boolean,
-        required: false,
         default:  false,
       },
       success:   {
         type:     Boolean,
-        required: false,
         default:  false,
       },
     },

diff --git a/src/app/shared/components/VueModal/VueModal.vue b/src/app/shared/components/VueModal/VueModal.vue
@@ -17,13 +17,11 @@
     name:    'VueModal',
     props:   {
       show:       {
-        required: false,
         default:  false,
         type:     Boolean,
       },
       fitContent: {
         type:     Boolean,
-        required: false,
         default:  false,
       },
     },

diff --git a/src/app/shared/components/VueNotificationStack/VueNotificationStack.vue b/src/app/shared/components/VueNotificationStack/VueNotificationStack.vue
@@ -23,7 +23,6 @@
     props:    {
       duration: {
         type:     Number,
-        required: false,
         default:  10000,
       },
     },

diff --git a/src/app/shared/components/VueSelect/VueSelect.vue b/src/app/shared/components/VueSelect/VueSelect.vue
@@ -54,7 +54,6 @@
       value:        {
         type:     String,
         default:  '',
-        required: false,
       },
       multiple:     {
         default: false,

diff --git a/src/app/shared/components/VueSidebar/VueSidebarGroupItem/VueSidebarGroupItem.vue b/src/app/shared/components/VueSidebar/VueSidebarGroupItem/VueSidebarGroupItem.vue
@@ -18,8 +18,7 @@
     components: {},
     props:      {
       to: {
-        type:    String,
-        default: null,
+        type: String,
       },
     },
     data(): any {