refactor(components): remove unused default props

vuesion · Dec 30, 2018 · 270759e · 270759e
1 parent 62569a6
commit 270759e
Show file tree

Hide file tree

Showing 21 changed files with 45 additions and 92 deletions.
diff --git a/src/app/shared/components/VueBadge/VueBadge.vue b/src/app/shared/components/VueBadge/VueBadge.vue
@@ -11,7 +11,6 @@ export default {
     },
     outlined: {
       type: Boolean,
-      default: false,
     },
   },
   computed: {

diff --git a/src/app/shared/components/VueButton/VueButton.vue b/src/app/shared/components/VueButton/VueButton.vue
@@ -16,19 +16,15 @@ export default {
     },
     disabled: {
       type: Boolean,
-      default: false,
     },
     loading: {
       type: Boolean,
-      default: false,
     },
     outlined: {
       type: Boolean,
-      default: false,
     },
     ghost: {
       type: Boolean,
-      default: false,
     },
   },
   components: {
@@ -38,28 +34,28 @@ export default {
     cssClasses() {
       const classes = [this.$style.button, this.$style.ripple];
 
-      if (this.outlined === true || this.ghost) {
+      if (this.outlined || this.ghost) {
         classes.push(this.$style.outlined);
       }
-      if (this.ghost === true) {
+      if (this.ghost) {
         classes.push(this.$style.ghost);
       }
       if (this.color) {
         classes.push(this.$style[this.color]);
       }
-      if (this.disabled === true || this.loading === true) {
+      if (this.disabled || this.loading) {
         classes.push(this.$style.disabled);
       }
 
       return classes;
     },
     actualWidth() {
-      return this.loading === true && this.$refs.button ? `${this.$refs.button.getBoundingClientRect().width}px` : null;
+      return this.loading && this.$refs.button ? `${this.$refs.button.getBoundingClientRect().width}px` : null;
     },
   },
   methods: {
     click(e: Event) {
-      if (this.disabled === false && this.loading === false) {
+      if (!this.disabled && !this.loading) {
         this.$emit('click', e);
       }
     },

diff --git a/src/app/shared/components/VueCard/VueCardHeader/VueCardHeader.vue b/src/app/shared/components/VueCard/VueCardHeader/VueCardHeader.vue
@@ -14,15 +14,12 @@ export default {
   props: {
     title: {
       type: String,
-      default: '',
     },
     subtitle: {
       type: String,
-      default: '',
     },
     image: {
       type: String,
-      default: '',
     },
   },
   computed: {

diff --git a/src/app/shared/components/VueCheckbox/VueCheckbox.vue b/src/app/shared/components/VueCheckbox/VueCheckbox.vue
@@ -38,26 +38,21 @@ export default {
     },
     checked: {
       type: Boolean,
-      default: false,
     },
     value: {
       type: Boolean,
-      default: false,
     },
     disabled: {
       type: Boolean,
-      default: false,
     },
     required: {
       type: Boolean,
-      default: false,
     },
     validation: {
-      default: '',
+      type: String,
     },
     radio: {
       type: Boolean,
-      default: false,
     },
     label: {
       type: String,
@@ -92,7 +87,7 @@ export default {
     onClick(e: Event) {
       e.preventDefault();
 
-      if (this.disabled === false) {
+      if (!this.disabled) {
         this.$emit('click', e);
         this.$emit('input', !Boolean(this.value));
       }

diff --git a/src/app/shared/components/VueDatePicker/VueDatePicker.stories.ts b/src/app/shared/components/VueDatePicker/VueDatePicker.stories.ts
@@ -10,7 +10,7 @@ story.add(
   'Default',
   withInfo({})(() => ({
     components: { VueDatePicker },
-    template: `<vue-date-picker @change="action" :first-day-of-week="1" placeholder="Select a date" />`,
+    template: `<vue-date-picker name="date" id="date" @change="action" :first-day-of-week="1" placeholder="Select a date" />`,
     i18n,
     methods: {
       action: action('@change'),

diff --git a/src/app/shared/components/VueDatePicker/VueDatePicker.vue b/src/app/shared/components/VueDatePicker/VueDatePicker.vue
@@ -1,5 +1,5 @@
 <template>
-  <div :class="$style.vueDatePicker" @click="show = true;">
+  <div :class="$style.vueDatePicker" @click="show = true">
     <vue-input
       :name="name"
       :id="id"
@@ -11,7 +11,7 @@
       :message="message"
       @focus="onFocus"
     />
-    <vue-modal :show="show" :fit-content="true" @close="show = false;">
+    <vue-modal :show="show" :fit-content="true" @close="show = false">
       <vue-calendar
         :min-date="minDate"
         :max-date="maxDate"
@@ -20,7 +20,7 @@
         :selected-date="date"
         :start-date="startDate"
         :end-date="endDate"
-        @close="show = false;"
+        @close="show = false"
         @change="onChange"
       >
       </vue-calendar>
@@ -43,11 +43,11 @@ export default {
   props: {
     name: {
       type: String,
-      default: 'date',
+      required: true,
     },
     id: {
       type: String,
-      default: 'date',
+      required: true,
     },
     minDate: {
       type: Date,
@@ -61,7 +61,6 @@ export default {
     },
     placeholder: {
       type: String,
-      default: '',
     },
     startDate: {
       type: Date,
@@ -74,19 +73,15 @@ export default {
     },
     required: {
       type: Boolean,
-      default: false,
     },
     disabled: {
       type: Boolean,
-      default: false,
     },
     readonly: {
       type: Boolean,
-      default: true,
     },
     message: {
       type: String,
-      default: '',
     },
   },
   data(): any {

diff --git a/src/app/shared/components/VueDateRangePicker/VueDateRangePicker.vue b/src/app/shared/components/VueDateRangePicker/VueDateRangePicker.vue
@@ -46,11 +46,9 @@ export default {
     },
     placeholderStart: {
       type: String,
-      default: '',
     },
     placeholderEnd: {
       type: String,
-      default: '',
     },
   },
   data(): any {
@@ -77,6 +75,5 @@ export default {
 
 <style lang="scss" module>
 .vueDateRangePicker {
-  display: block;
 }
 </style>
diff --git a/src/app/shared/components/VueDonutChart/VueDonutChart.vue b/src/app/shared/components/VueDonutChart/VueDonutChart.vue
@@ -49,15 +49,13 @@ export default {
   props: {
     title: {
       type: String,
-      default: '',
     },
     data: {
       type: Array,
-      default: [],
+      required: true,
     },
     unit: {
       type: String,
-      default: '',
     },
     strokeWidth: {
       type: Number,

diff --git a/src/app/shared/components/VueInput/VueInput.stories.ts b/src/app/shared/components/VueInput/VueInput.stories.ts
@@ -86,7 +86,7 @@ story.add(
 
   <vue-modal :show="show" @close="show = false">
     <vue-input autofocus placeholder="Name" name="name" id="name" v-model="model" />
-    <vue-button @click="show = !show">Close</vue-button>
+    <vue-button color="primary" ghost @click="show = !show">Close</vue-button>
   </vue-modal>
 </div>`,
   })),

diff --git a/src/app/shared/components/VueInput/VueInput.vue b/src/app/shared/components/VueInput/VueInput.vue
@@ -44,42 +44,34 @@ export default {
     },
     placeholder: {
       type: String,
-      default: '',
     },
     required: {
       type: Boolean,
-      default: false,
     },
     autofocus: {
       type: Boolean,
-      default: false,
     },
     value: {
       type: String,
-      default: '',
     },
     type: {
       type: String,
       default: 'text',
     },
     disabled: {
       type: Boolean,
-      default: false,
     },
     readonly: {
       type: Boolean,
-      default: false,
     },
     message: {
       type: String,
-      default: '',
     },
     errorMessage: {
       type: String,
-      default: '',
     },
     validation: {
-      default: '',
+      type: String,
     },
     autocomplete: {
       default: 'off',

diff --git a/src/app/shared/components/VueLoader/VueLoader.vue b/src/app/shared/components/VueLoader/VueLoader.vue
@@ -20,11 +20,9 @@ export default {
   props: {
     medium: {
       type: Boolean,
-      default: false,
     },
     large: {
       type: Boolean,
-      default: false,
     },
     color: {
       type: String,

diff --git a/src/app/shared/components/VueModal/VueModal.vue b/src/app/shared/components/VueModal/VueModal.vue
@@ -1,6 +1,8 @@
 <template>
   <transition @beforeEnter="beforeEnter" @enter="enter" @beforeLeave="beforeLeave" @leave="leave">
-    <div :class="[$style.vueModal, fitContent ? $style.fitContent : '']" v-if="show" ref="modal"><slot /></div>
+    <div :class="[$style.vueModal, fitContent ? $style.fitContent : '']" v-if="show" :aria-modal="show" ref="modal">
+      <slot />
+    </div>
   </transition>
 </template>
 
@@ -11,12 +13,10 @@ export default {
   name: 'VueModal',
   props: {
     show: {
-      default: false,
       type: Boolean,
     },
     fitContent: {
       type: Boolean,
-      default: false,
     },
   },
   methods: {

diff --git a/src/app/shared/components/VueNavBar/VueNavBar.vue b/src/app/shared/components/VueNavBar/VueNavBar.vue
@@ -5,12 +5,6 @@
 <script lang="ts">
 export default {
   name: 'VueNavBar',
-  components: {},
-  data() {
-    return {};
-  },
-  props: {},
-  computed: {},
 };
 </script>
 

diff --git a/src/app/shared/components/VueSelect/VueSelect.vue b/src/app/shared/components/VueSelect/VueSelect.vue
@@ -17,7 +17,7 @@
         {{ option.label }}
       </option>
     </select>
-    <i :class="$style.icon" v-if="multiple === false" />
+    <i :class="$style.icon" v-if="!multiple" />
   </div>
 </template>
 
@@ -55,26 +55,22 @@ export default {
       default: '',
     },
     multiple: {
-      default: false,
       type: Boolean,
     },
     required: {
-      default: false,
       type: Boolean,
     },
     disabled: {
-      default: false,
       type: Boolean,
     },
     validation: {
-      default: '',
+      type: String,
     },
     autocomplete: {
       default: 'off',
     },
     placeholder: {
       type: String,
-      default: '',
     },
   },
   computed: {

diff --git a/src/app/shared/components/VueSidebar/VueSidebar.vue b/src/app/shared/components/VueSidebar/VueSidebar.vue
@@ -1,6 +1,6 @@
 <template>
   <aside ref="sidebar">
-    <button :class="hamburgerCssClasses" type="button" aria-label="menu" @click="open = !open;">
+    <button :class="hamburgerCssClasses" type="button" aria-label="menu" @click="open = !open">
       <span :class="$style.box"> <span :class="$style.inner" /> </span>
     </button>
     <div :class="sidebarClasses"><slot /></div>
@@ -10,8 +10,6 @@
 <script lang="ts">
 export default {
   name: 'VueSidebar',
-  components: {},
-  props: {},
   data(): any {
     return {
       open: false,