Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Add more specific classes to the buttons in MdDialogConfirm #1622

Closed
mattgrande opened this issue Mar 23, 2018 · 3 comments
Closed

Suggestion: Add more specific classes to the buttons in MdDialogConfirm #1622

mattgrande opened this issue Mar 23, 2018 · 3 comments

Comments

@mattgrande
Copy link
Contributor

I came across this while writing some E2E tests. It's difficult to target the buttons in the current implementation of MdDialogConfirm, as they are both rendered the same.

I think it would be nice to see some classes added to the buttons, eg, md-dialog-confirm-button and md-dialog-cancel-button to make CSS & testing targeting easier.

If others agree, I'm more than willing to make a PR.
@Samuell1
Copy link
Member

I think in MdDialogConfirm component should not be close button with md-primary class, then it will be easy to target buttons.

@mattgrande
Copy link
Contributor Author

Agreed; Should it be md-accent, or just nothing?

@Samuell1
Copy link
Member

@mattgrande just nothing, accent means more like "danger" button :D

mattgrande pushed a commit to mattgrande/vue-material that referenced this issue Mar 27, 2018
Remove md-primary from MdDialogConfirm's cancel button
c385b3e 
As recommended in vuematerial#1622
@mattgrande mattgrande mentioned this issue Mar 27, 2018
Merged
marcosmoura pushed a commit that referenced this issue Mar 27, 2018
@marcosmoura
fix(MdDialog): remove md-primary from MdDialogConfirm's cancel button (…
e125c0d 
…#1633)

As recommended in #1622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattgrande @Samuell1