Docs: Clarify getter cache behavior #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
changed the title
|
Nice! |
kazupon
added a commit
to kazupon/vuex
that referenced
this pull request
Jul 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reviewing getters docs, it was not clear whether the results of a getter were cached. This is alluded to in the remark "think of them as computed properties for stores", and in reviewing the source it's seen that they are in-fact computed properties under the hood, but I think the docs could benefit from describing this behavior more explicitly. In fact, this alone is a compelling feature of Vuex, as unlike Redux which requires a library like Reselect (or my own Rememo), Vuex has caching built-in to its selector equivalents.