fix .toggle-all checkbox was hidden #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
reviewed
Apr 29, 2017
| @@ -13,10 +13,11 @@ | |||
| </header> | |||
| <!-- main section --> | |||
| <section class="main" v-show="todos.length"> | |||
| <input class="toggle-all" | |||
| <input class="toggle-all" id="toggle-all" | |||
There was a problem hiding this comment.
where does the id come from? It's not on the todomvc repo
There was a problem hiding this comment.
Yes, it's not. The checkbox arrow(.toggle-all) need a label tag next to it, and can't be wrapped with label, because it was written like this in todomvc-app-css:
.toggle-all + label:before {
content: '❯';
font-size: 22px;
color: #e6e6e6;
padding: 10px 27px 10px 27px;
}Then if i want to click the arrow and trigger the event, need to bind the label tag to input with the for attribute, so i set id on input. Is there any other way better than this?
There was a problem hiding this comment.
I see, yeah the + doesn't leave us other option here (at least none that I'm aware of)
ktsn
approved these changes
May 14, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see tastejs/todomvc-app-css#8.
todomvc-app-cssupgraded version to2.1.0,"todomvc-app-css": "^2.0.6"in vuex's package.json will download latest version,.toggle-allclass has a big change, causing it to be hidden in todomvc example.