Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly remove once listener with event handler return null #11281 #11282

Closed
wants to merge 1 commit into from

Conversation

zhangchen915
Copy link

@zhangchen915 zhangchen915 commented Apr 5, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@posva
Copy link
Member

posva commented Apr 5, 2020

note: this needs to wait for confirmation (#11281 (comment))

@posva
Copy link
Member

posva commented Apr 6, 2020

Thanks for the PR but it turns out this would break an existing behavior with .self (See #11281 (comment))

@posva posva closed this Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants