fix: improve slots mounting option #821
Conversation
|
I will add some tests and improvements within 3 days. |
38elements
force-pushed
the
slots
branch
6 times, most recently
from
955689d to
4fc7323
Compare
38elements
changed the title
38elements
force-pushed
the
slots
branch
4 times, most recently
from
962d5ef to
da3e193
Compare
| slotValue: Component | string | ||
| ): ?Array<VNode> { | ||
| if (typeof slotValue === 'string') { | ||
| const compiledResult = compileToFunctions(`<div>${slotValue}{{ }}</div>`) |
There was a problem hiding this comment.
Why the empty interpolation {{ }}?
There was a problem hiding this comment.
I do not understand.
It is not necessary.
I thought the compileToFunctions raises an error if it dose not exist at #274.
|
I think it is necessary to add warning if |
| // it is not necessary to check compileToFunctions. | ||
| const compiledResult = compileToFunctions(`<div>${slotValue}</div>`) | ||
| const _staticRenderFns = vm._renderProxy.$options.staticRenderFns | ||
| vm._renderProxy.$options.staticRenderFns = compiledResult.staticRenderFns |
There was a problem hiding this comment.
Why do you save the renderFunctions and then reassign?
| () => { | ||
| const wrapper1 = mount(ComponentWithSlots, { slots: { default: 'foo<span>123</span>{{ foo }}' }}) | ||
| expect(wrapper1.find('main').html()).to.equal('<main>foo<span>123</span>bar</main>') | ||
| const wrapper2 = mount(ComponentWithSlots, { slots: { default: '<p>1</p>{{ foo }}2' }}) |
There was a problem hiding this comment.
I don't think this is how slots should behave. foo should not be resolved using the child vm that it's rendered in. If it uses any instance to resolve foo on, it should be the root instance. But I don't think we should support any variables in the slots option as it adds too much complexity
There was a problem hiding this comment.
I am sorry.
Your pointing out is correct.
I misunderstood about it.
| return [vm.$createElement(slotValue)] | ||
| } | ||
|
|
||
| export default function createRenderSlot ( |
There was a problem hiding this comment.
What is the purpose of replacing the renderSlot alias? Does this solve the issue of parent being undefined?
This resolves #793.
This is related to #813.
This does not reslove #827.