fix: clone propsData to avoid mutation #613
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fix #393.
In the issue it was mentioned that cloning might cause other problems with stubbing. Was wondering if doing this might break it? Seems like all other tests are passing, maybe I'm missing something 🤔 @eddyerburgh
Also, I've added a test to make sure it won't happen again, but I am not sure if this is the best way to do it, whether it belongs to
mounting-options
or not, whether the test structure adheres the repo standard, etc. I'm open for suggestions.Thanks.