Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clone propsData to avoid mutation #613

Merged
merged 3 commits into from
May 16, 2018
Merged

Conversation

briwa
Copy link
Contributor

@briwa briwa commented May 15, 2018

Potentially fix #393.

In the issue it was mentioned that cloning might cause other problems with stubbing. Was wondering if doing this might break it? Seems like all other tests are passing, maybe I'm missing something 🤔 @eddyerburgh

Also, I've added a test to make sure it won't happen again, but I am not sure if this is the best way to do it, whether it belongs to mounting-options or not, whether the test structure adheres the repo standard, etc. I'm open for suggestions.

Thanks.

@eddyerburgh
Copy link
Member

Cloning will be fine with stubs. I thought cloning a function would break the reference, but I was wrong.

You need to fix a flow error. You can add a propsData property to the options object in flow/options.flow.js.

Then I'm happy to merge 👍

@briwa
Copy link
Contributor Author

briwa commented May 15, 2018

Alright, fixed @eddyerburgh. Thanks.

@eddyerburgh
Copy link
Member

Thanks for the quick fix

@eddyerburgh eddyerburgh merged commit a93275c into vuejs:dev May 16, 2018
@briwa briwa deleted the fix-propsdata branch May 18, 2018 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default props modified between tests suites
2 participants