Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Array.prototype.includes and Array.prototype.findIndex (fix #608) #610

Merged
merged 1 commit into from
May 15, 2018

Conversation

honeroku
Copy link
Contributor

@honeroku honeroku commented May 15, 2018

TODO

@lusarz
Copy link
Contributor

lusarz commented May 15, 2018

Great finding!

@honeroku honeroku changed the title [WIP] Remove Array.prototype.includes and Array.prototype.findIndex (fix #608) Remove Array.prototype.includes and Array.prototype.findIndex (fix #608) May 15, 2018
@honeroku
Copy link
Contributor Author

@eddyerburgh I investigated eslint-plugin-compat with browserslist: ["last 1 versions", "Explorer >= 9"] according to vue supported browsers but had no luck to pick up those includes and findIndex on dev branch.
And I have no other idea to detect browser compatibility.

Ashamed of myself but would you mind merging this PR without systematic testimony?

Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@eddyerburgh eddyerburgh merged commit a70a887 into vuejs:dev May 15, 2018
@honeroku
Copy link
Contributor Author

Thank you!!

@eddyerburgh
Copy link
Member

eddyerburgh commented May 15, 2018

The eslint-compat-plugin doesn't catch lots of unsupported features right now—amilajack/eslint-plugin-compat#72 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants