Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add setValue method #557

Merged
merged 7 commits into from
Jun 9, 2018
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flow/wrapper.flow.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ declare interface BaseWrapper { // eslint-disable-line no-undef
setData(data: Object): void,
setComputed(computed: Object): void,
setMethods(methods: Object): void,
setValue(value: any): void,
setChecked(checked: boolean): void,
setSelected(): void,
setProps(data: Object): void,
trigger(type: string, options: Object): void,
destroy(): void
Expand Down
12 changes: 12 additions & 0 deletions packages/test-utils/src/error-wrapper.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,18 @@ export default class ErrorWrapper implements BaseWrapper {
throwError(`find did not return ${this.selector}, cannot call setProps() on empty Wrapper`)
}

setValue (): void {
throwError(`find did not return ${this.selector}, cannot call setValue() on empty Wrapper`)
}

setChecked (): void {
throwError(`find did not return ${this.selector}, cannot call setChecked() on empty Wrapper`)
}

setSelected (): void {
throwError(`find did not return ${this.selector}, cannot call setSelected() on empty Wrapper`)
}

trigger (): void {
throwError(`find did not return ${this.selector}, cannot call trigger() on empty Wrapper`)
}
Expand Down
18 changes: 18 additions & 0 deletions packages/test-utils/src/wrapper-array.js
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,24 @@ export default class WrapperArray implements BaseWrapper {
this.wrappers.forEach(wrapper => wrapper.setProps(props))
}

setValue (value: any): void {
this.throwErrorIfWrappersIsEmpty('setValue')

this.wrappers.forEach(wrapper => wrapper.setValue(value))
}

setChecked (checked: boolean): void {
this.throwErrorIfWrappersIsEmpty('setChecked')

this.wrappers.forEach(wrapper => wrapper.setChecked(checked))
}

setSelected (): void {
this.throwErrorIfWrappersIsEmpty('setSelected')

throwError('setSelected must be called on a single wrapper, use at(i) to access a wrapper')
}

trigger (event: string, options: Object): void {
this.throwErrorIfWrappersIsEmpty('trigger')

Expand Down
110 changes: 110 additions & 0 deletions packages/test-utils/src/wrapper.js
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,116 @@ export default class Wrapper implements BaseWrapper {
this.vnode = this.vm._vnode
}

/**
* Sets element value and triggers input event
*/
setValue (value: any) {
const el = this.element

if (!el) {
throwError('cannot call wrapper.setValue() on a wrapper without an element')
}

const tag = el.tagName
const type = this.attributes().type
const event = 'input'

if (tag === 'SELECT') {
throwError('wrapper.setValue() cannot be called on select')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can tell the user to call setSelected(). Also, can you change the errors to this format:

wrapper.setValue() cannot be called on a <select> element. Use wrapper.setSelected() instead

} else if (tag === 'INPUT' && type === 'checkbox') {
throwError('wrapper.setValue() cannot be called on checkbox. Use wrapper.setChecked() instead')
} else if (tag === 'INPUT' && type === 'radio') {
throwError('wrapper.setValue() cannot be called on radio. Use wrapper.setChecked() instead')
} else if (tag === 'INPUT' || tag === 'textarea') {
// $FlowIgnore
el.value = value
this.trigger(event)
} else {
throwError('wrapper.setValue() cannot be called on this element')
}
}

/**
* Checks radio button or checkbox element
*/
setChecked (checked: boolean) {
if (typeof checked !== 'undefined') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should default to true, so you can call setChecked() and it will set the element to checked. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is set to true if no argument is passed. It isn't set on the parameters as a default but it behaves the way you suggest, there is a test for this specific case.

if (typeof checked !== 'boolean') {
throwError('wrapper.setChecked() must be passed a boolean')
}
} else {
checked = true
}

const el = this.element

if (!el) {
throwError('cannot call wrapper.setChecked() on a wrapper without an element')
}

const tag = el.tagName
const type = this.attributes().type
const event = 'change'

if (this.isVueComponent) {
throwError('wrapper.setChecked() cannot be called on component. Use wrapper.setValue() instead')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A component instance still has a root element, which can have its value set, so I think we should let setChecked work for vue instance wrappers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is related to how v-model behaves on components, but Im not sure. Let me know your final decision

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The v-model would be set on the root element, so if you have a component like this:

<template>
  <input type="text" />
</template>

And you called setValue, you would set the value of the input:

const wrapper = mount(TestComponent)
wrapper.setValue('some val')

All component instance wrappers have a root element (this.element) so you can keep the current code and it would work correctly on instance wrappers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this check for isVueComponent

} else if (tag === 'SELECT') {
throwError('wrapper.setChecked() cannot be called on select')
} else if (tag === 'INPUT' && type === 'checkbox') {
// $FlowIgnore
if (el.checked !== checked) {
this.trigger('click')
this.trigger(event)
}
} else if (tag === 'INPUT' && type === 'radio') {
if (!checked) {
throwError('wrapper.setChecked() cannot be called with parameter false on radio')
} else {
// $FlowIgnore
if (!el.checked) {
this.trigger('click')
this.trigger(event)
}
}
} else if (tag === 'INPUT' || tag === 'textarea') {
throwError('wrapper.setChecked() cannot be called on "text" inputs. Use wrapper.setValue() instead')
} else {
throwError('wrapper.setChecked() cannot be called on this element')
}
}

/**
* Selects <option></option> element
*/
setSelected () {
const el = this.element

if (!el) {
throwError('cannot call wrapper.setSelected() on a wrapper without an element')
}

const tag = el.tagName
const type = this.attributes().type
const event = 'change'

if (tag === 'OPTION') {
// $FlowIgnore
el.selected = true
// $FlowIgnore
createWrapper(el.parentElement, this.options).trigger(event)
} else if (tag === 'SELECT') {
throwError('wrapper.setSelected() cannot be called on select. Call it on one of its options')
} else if (tag === 'INPUT' && type === 'checkbox') {
throwError('wrapper.setSelected() cannot be called on checkbox. Use wrapper.setChecked() instead')
} else if (tag === 'INPUT' && type === 'radio') {
throwError('wrapper.setSelected() cannot be called on radio. Use wrapper.setChecked() instead')
} else if (tag === 'INPUT' || tag === 'textarea') {
throwError('wrapper.setSelected() cannot be called on "text" inputs. Use wrapper.setValue() instead')
} else {
throwError('wrapper.setSelected() cannot be called on this element')
}
}

/**
* Return text of wrapper element
*/
Expand Down
5 changes: 5 additions & 0 deletions packages/test-utils/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ interface BaseWrapper {
setData (data: object): void
setMethods (data: object): void
setProps (props: object): void

setValue (value: any): void
setChecked (checked: boolean): void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setSelected is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, sorry. Done


trigger (eventName: string, options?: object): void
destroy (): void
}
Expand All @@ -98,6 +102,7 @@ export interface Wrapper<V extends Vue> extends BaseWrapper {
html (): string
text (): string
name (): string
setSelected(): void

emitted (event?: string): { [name: string]: Array<Array<any>> }
emittedByOrder (): Array<{ name: string, args: Array<any> }>
Expand Down
4 changes: 4 additions & 0 deletions packages/test-utils/types/test/wrapper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ array = wrapper.findAll(ClassComponent)
array = wrapper.findAll({ ref: 'myButton' })
array = wrapper.findAll({ name: 'my-button' })

wrapper.setChecked(true)
wrapper.setValue('some string')
wrapper.setSelected()

let str: string = wrapper.html()
str = wrapper.text()
str = wrapper.name()
Expand Down
44 changes: 44 additions & 0 deletions test/resources/components/component-with-input.vue
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
<template>
<div>
<input type="checkbox" v-model="checkboxVal">
<input type="radio" v-model="radioVal" id="radioFoo" value="radioFooResult">
<input type="radio" v-model="radioVal" id="radioBar" value="radioBarResult">
<input type="text" v-model="textVal">
<select v-model="selectVal">
<option value="selectA"></option>
<option value="selectB"></option>
<option value="selectC"></option>
</select>
<label id="label-el"></label>

<span class="checkboxResult" v-if="checkboxVal">checkbox checked</span>
<span class="counter">{{ counter }}</span>
{{ textVal }}
{{ selectVal }}
{{ radioVal }}
</div>
</template>

<script>
export default {
name: 'component-with-input',
data () {
return {
checkboxVal: undefined,
textVal: undefined,
radioVal: undefined,
selectVal: undefined,
counter: 0
}
},

watch: {
checkboxVal () {
this.counter++
},
radioVal () {
this.counter++
}
}
}
</script>
141 changes: 141 additions & 0 deletions test/specs/wrapper/setChecked.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,141 @@
import ComponentWithInput from '~resources/components/component-with-input.vue'
import { describeWithShallowAndMount } from '~resources/utils'

describeWithShallowAndMount('setChecked', (mountingMethod) => {
it('sets element checked true with no option passed', () => {
const wrapper = mountingMethod(ComponentWithInput)
const input = wrapper.find('input[type="checkbox"]')
input.setChecked()

expect(input.element.checked).to.equal(true)
})

it('sets element checked equal to param passed', () => {
const wrapper = mountingMethod(ComponentWithInput)
const input = wrapper.find('input[type="checkbox"]')

input.setChecked(true)
expect(input.element.checked).to.equal(true)

input.setChecked(false)
expect(input.element.checked).to.equal(false)
})

it('calls trigger with change event on checkbox', () => {
const wrapper = mountingMethod(ComponentWithInput)
const input = wrapper.find('input[type="checkbox"]')
sinon.spy(input, 'trigger')

input.setChecked()

expect(input.trigger.called).to.equal(true)
expect(input.trigger.args[0][0]).to.equal('click')
expect(input.trigger.args[1][0]).to.equal('change')
})

it('calls trigger with change event on radio', () => {
const wrapper = mountingMethod(ComponentWithInput)
const input = wrapper.find('#radioBar')
sinon.spy(input, 'trigger')

input.setChecked()

expect(input.trigger.called).to.equal(true)
expect(input.trigger.args[0][0]).to.equal('click')
expect(input.trigger.args[1][0]).to.equal('change')
})

it('updates dom with checkbox v-model', () => {
const wrapper = mountingMethod(ComponentWithInput)
const input = wrapper.find('input[type="checkbox"]')

input.setChecked()
expect(wrapper.text()).to.contain('checkbox checked')

input.setChecked(false)
expect(wrapper.text()).to.not.contain('checkbox checked')
})

it('changes state the right amount of times with checkbox v-model', () => {
const wrapper = mountingMethod(ComponentWithInput)
const input = wrapper.find('input[type="checkbox"]')

input.setChecked()
input.setChecked(false)
input.setChecked(false)
input.setChecked(true)
input.setChecked(false)
input.setChecked(false)

expect(wrapper.find('.counter').text()).to.equal('4')
})

it('updates dom with radio v-model', () => {
const wrapper = mountingMethod(ComponentWithInput)

wrapper.find('#radioBar').setChecked()
expect(wrapper.text()).to.contain('radioBarResult')

wrapper.find('#radioFoo').setChecked()
expect(wrapper.text()).to.contain('radioFooResult')
})

it('changes state the right amount of times with checkbox v-model', () => {
const wrapper = mountingMethod(ComponentWithInput)
const radioBar = wrapper.find('#radioBar')
const radioFoo = wrapper.find('#radioFoo')

radioBar.setChecked()
radioBar.setChecked()
radioFoo.setChecked()
radioBar.setChecked()
radioBar.setChecked()
radioFoo.setChecked()
radioFoo.setChecked()

expect(wrapper.find('.counter').text()).to.equal('4')
})

it('throws error if checked param is not boolean', () => {
const message = 'wrapper.setChecked() must be passed a boolean'
shouldThrowErrorOnElement('input[type="checkbox"]', message, 'asd')
})

it('throws error if checked param is false on radio element', () => {
const message = 'wrapper.setChecked() cannot be called with parameter false on radio'
shouldThrowErrorOnElement('#radioFoo', message, false)
})

it('throws error if wrapper does not contain element', () => {
const wrapper = mountingMethod({ render: (h) => h('div') })
const div = wrapper.find('div')
div.element = null

const fn = () => div.setChecked()
const message = '[vue-test-utils]: cannot call wrapper.setChecked() on a wrapper without an element'
expect(fn).to.throw().with.property('message', message)
})

it('throws error if element is select', () => {
const message = 'wrapper.setChecked() cannot be called on select'
shouldThrowErrorOnElement('select', message)
})

it('throws error if element is text like', () => {
const message = 'wrapper.setChecked() cannot be called on "text" inputs. Use wrapper.setValue() instead'
shouldThrowErrorOnElement('input[type="text"]', message)
})

it('throws error if element is not valid', () => {
const message = 'wrapper.setChecked() cannot be called on this element'
shouldThrowErrorOnElement('#label-el', message)
})

function shouldThrowErrorOnElement (selector, message, value) {
const wrapper = mountingMethod(ComponentWithInput)
const input = wrapper.find(selector)

const fn = () => input.setChecked(value)
expect(fn).to.throw().with.property('message', '[vue-test-utils]: ' + message)
}
})
Loading