-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add setValue method #557
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b600bbc
added setValue method and few tests
beyer-martin a955dec
Added setChecked
beyer-martin 241e772
Fixed error wrapper and wrapper array missing methods
beyer-martin 5e243ca
Fixed Flow errors on element Object
beyer-martin 37150d5
Added setSelected method
beyer-martin 4fddcd1
Fixed v-model not updating on 2.1.10
beyer-martin 2e91724
Minor changes
beyer-martin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,6 +72,11 @@ interface BaseWrapper { | |
setData (data: object): void | ||
setMethods (data: object): void | ||
setProps (props: object): void | ||
|
||
setValue (value: any): void | ||
setChecked (checked: boolean): void | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. setSelected is missing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ups, sorry. Done |
||
setSelected (): void | ||
|
||
trigger (eventName: string, options?: object): void | ||
destroy (): void | ||
} | ||
|
@@ -98,6 +103,7 @@ export interface Wrapper<V extends Vue> extends BaseWrapper { | |
html (): string | ||
text (): string | ||
name (): string | ||
setSelected(): void | ||
|
||
emitted (event?: string): { [name: string]: Array<Array<any>> } | ||
emittedByOrder (): Array<{ name: string, args: Array<any> }> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
<template> | ||
<div> | ||
<input type="checkbox" v-model="checkboxVal"> | ||
<input type="radio" v-model="radioVal" id="radioFoo" value="radioFooResult"> | ||
<input type="radio" v-model="radioVal" id="radioBar" value="radioBarResult"> | ||
<input type="text" v-model="textVal"> | ||
<select v-model="selectVal"> | ||
<option value="selectA"></option> | ||
<option value="selectB"></option> | ||
<option value="selectC"></option> | ||
</select> | ||
<label id="label-el"></label> | ||
|
||
<span class="checkboxResult" v-if="checkboxVal">checkbox checked</span> | ||
<span class="counter">{{ counter }}</span> | ||
{{ textVal }} | ||
{{ selectVal }} | ||
{{ radioVal }} | ||
</div> | ||
</template> | ||
|
||
<script> | ||
export default { | ||
name: 'component-with-input', | ||
data () { | ||
return { | ||
checkboxVal: undefined, | ||
textVal: undefined, | ||
radioVal: undefined, | ||
selectVal: undefined, | ||
counter: 0 | ||
} | ||
}, | ||
|
||
watch: { | ||
checkboxVal () { | ||
this.counter++ | ||
}, | ||
radioVal () { | ||
this.counter++ | ||
} | ||
} | ||
} | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,117 @@ | ||
import ComponentWithInput from '~resources/components/component-with-input.vue' | ||
import { describeWithShallowAndMount } from '~resources/utils' | ||
|
||
describeWithShallowAndMount('setChecked', (mountingMethod) => { | ||
it('sets element checked true with no option passed', () => { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
const input = wrapper.find('input[type="checkbox"]') | ||
input.setChecked() | ||
|
||
expect(input.element.checked).to.equal(true) | ||
}) | ||
|
||
it('sets element checked equal to param passed', () => { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
const input = wrapper.find('input[type="checkbox"]') | ||
|
||
input.setChecked(true) | ||
expect(input.element.checked).to.equal(true) | ||
|
||
input.setChecked(false) | ||
expect(input.element.checked).to.equal(false) | ||
}) | ||
|
||
it('updates dom with checkbox v-model', () => { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
const input = wrapper.find('input[type="checkbox"]') | ||
|
||
input.setChecked() | ||
expect(wrapper.text()).to.contain('checkbox checked') | ||
|
||
input.setChecked(false) | ||
expect(wrapper.text()).to.not.contain('checkbox checked') | ||
}) | ||
|
||
it('changes state the right amount of times with checkbox v-model', () => { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
const input = wrapper.find('input[type="checkbox"]') | ||
|
||
input.setChecked() | ||
input.setChecked(false) | ||
input.setChecked(false) | ||
input.setChecked(true) | ||
input.setChecked(false) | ||
input.setChecked(false) | ||
|
||
expect(wrapper.find('.counter').text()).to.equal('4') | ||
}) | ||
|
||
it('updates dom with radio v-model', () => { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
|
||
wrapper.find('#radioBar').setChecked() | ||
expect(wrapper.text()).to.contain('radioBarResult') | ||
|
||
wrapper.find('#radioFoo').setChecked() | ||
expect(wrapper.text()).to.contain('radioFooResult') | ||
}) | ||
|
||
it('changes state the right amount of times with checkbox v-model', () => { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
const radioBar = wrapper.find('#radioBar') | ||
const radioFoo = wrapper.find('#radioFoo') | ||
|
||
radioBar.setChecked() | ||
radioBar.setChecked() | ||
radioFoo.setChecked() | ||
radioBar.setChecked() | ||
radioBar.setChecked() | ||
radioFoo.setChecked() | ||
radioFoo.setChecked() | ||
|
||
expect(wrapper.find('.counter').text()).to.equal('4') | ||
}) | ||
|
||
it('throws error if checked param is not boolean', () => { | ||
const message = 'wrapper.setChecked() must be passed a boolean' | ||
shouldThrowErrorOnElement('input[type="checkbox"]', message, 'asd') | ||
}) | ||
|
||
it('throws error if checked param is false on radio element', () => { | ||
const message = 'wrapper.setChecked() cannot be called with parameter false on a <input type="radio" /> element.' | ||
shouldThrowErrorOnElement('#radioFoo', message, false) | ||
}) | ||
|
||
it('throws error if wrapper does not contain element', () => { | ||
const wrapper = mountingMethod({ render: (h) => h('div') }) | ||
const div = wrapper.find('div') | ||
div.element = null | ||
|
||
const fn = () => div.setChecked() | ||
const message = '[vue-test-utils]: cannot call wrapper.setChecked() on a wrapper without an element' | ||
expect(fn).to.throw().with.property('message', message) | ||
}) | ||
|
||
it('throws error if element is select', () => { | ||
const message = 'wrapper.setChecked() cannot be called on a <select> element. Use wrapper.setSelected() instead' | ||
shouldThrowErrorOnElement('select', message) | ||
}) | ||
|
||
it('throws error if element is text like', () => { | ||
const message = 'wrapper.setChecked() cannot be called on "text" inputs. Use wrapper.setValue() instead' | ||
shouldThrowErrorOnElement('input[type="text"]', message) | ||
}) | ||
|
||
it('throws error if element is not valid', () => { | ||
const message = 'wrapper.setChecked() cannot be called on this element' | ||
shouldThrowErrorOnElement('#label-el', message) | ||
}) | ||
|
||
function shouldThrowErrorOnElement (selector, message, value) { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
const input = wrapper.find(selector) | ||
|
||
const fn = () => input.setChecked(value) | ||
expect(fn).to.throw().with.property('message', '[vue-test-utils]: ' + message) | ||
} | ||
}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should default to true, so you can call setChecked() and it will set the element to checked. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is set to true if no argument is passed. It isn't set on the parameters as a default but it behaves the way you suggest, there is a test for this specific case.