Improved docs for nextTick and thrown errors #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyerburgh
reviewed
Nov 27, 2017
docs/en/guides/getting-started.md
Outdated
| it('will time out', (done) => { | ||
| Vue.nextTick(() => { | ||
| expect(true).toBe(false); | ||
| done(); |
There was a problem hiding this comment.
This will fail when you run npm run lint:docs.
For some reason it's not running inside CI.
Can you lint and fix the errors
|
Looks good, I'll merge once linting errors are fixed |
|
Done and pushed. There's a couple linting errors in the french docs too but figured you wouldn't want them fixed in this PR! |
eddyerburgh
approved these changes
Nov 28, 2017
|
Thanks Callum 😀 |
reyoucat
added a commit
to ChangJoo-Park/vue-test-utils
that referenced
this pull request
Nov 29, 2017
[fix] (vuejs#207) not translated.
eddyerburgh
pushed a commit
that referenced
this pull request
Dec 7, 2017
* Add Korean docs directory * Translate README.md * Update README.md * Translate getting-started in Korean * Fix emmitted in Korean * Translate common tips in Korean * Translate dom-events in Korean * Translate choosing a test runner in Korean * Translate testing SFCs with jest * Fix typo * Fix typo testing SFCs with jest * Translate testing SFCs with mocha with webpack in Korean * Translate vue-router heading in Korean * Add Korean to LANGS.md * Translate vue-router in Korean * Translate Vuex in Korean * Translate README mounting options in Korean * Translate mount in Korean * Translate selector in Korean * Translate shallow.md in Korean * Translate options in Korean * Translate mount in Korean * Translate createLocalVue in Korean * Translate config in Korean * Translate contains in Korean * Translate destroy in Korean * Translate emitted in Korean * Translate emittedByOrder in Korean * Translate exists in Korean * Translate find in Korean * Translate findAll in Korean * Translate hasAttribute in Korean * Translate hasClass in Korean * Translate hasProp in Korean * Translate hasStyle in Korean * Translate html in Korean * Translate is in Korean * Translate isEmpty in Korean * Translate isVueInstance in Korean * Translate name in Korean * Translate setComputed in Korean * Translate setData in Korean * Translate setMethods in Korean * Translate setProps in Korean * Translate text in Korean * Translate trigger in Korean * Translate update in Korean * Translate at in Korean * Translate wrapperArray in Korean * Translate README for wrapper in Korean * Translate README for wrapper-array in Korean * Translate transition and transition-group in Korean * Translate README header in Korean * Fix getting-started.md * Fix common-tips.md * FIx dom event * Fix testing mocha webpack * fix mocking in Korean * Resolve conflicts by portuguese * Update getting-started.md 문맥을 읽기 좋게 일부 수정 했습니다. * Fixing typo and incorrect link * Update common-tips.md 문장구조와 내용을 읽기 편하게 수정했습니다! * Update dom-events.md 문맥 및 내용을 보기좋게 수정하였습니다. * Update dom-events.md 문장 내 `options` 관련 일부 수정. * Update choosing-a-test-runner.md 문장구조와 내용을 읽기 편하게 수정했습니다! * Update README.md 삭제: 지원하지 않는 가이드 링크 삭제. * Update testing-SFCs-with-jest.md 문장구조와 내용을 읽기 편하게 수정했습니다! * Update testing-SFCs-with-mocha-webpack.md 문장구조와 내용 일부를 수정하였습니다. * Update using-with-vue-router.md [minor fix] 일부 문맥을 수정하였습니다. * Update using-with-vuex.md 전반적인 내용을 가다듬었습니다. * Update README.md minor fix. * Update config.md * Update mount.md [Fix] not translated. * Update options.md 한국어 문법수정. * Update README.md 한국어 문법 수정. * Update choosing-a-test-runner.md 한국어 문법 수정. * Update choosing-a-test-runner.md 한국어 문법 수정. * Update mount.md 일부 문장구조를 수정하였습니다. * Update mount.md [fix] not translated. * Update shallow.md [fix] not translated. * Update options.md [fix] some sentences. * Update README.md [fix] some sentences. * docs: improved docs for nextTick and thrown errors [fix] (#207) not translated. * Update emitted.md * [fix] minor sentence. * [fix] minor sentence. * [add] findAll. findAll 이 빠져있길래 추가했습니다. * [fix] minor sentence. * [fix] minor sentence. * [fix] minor sentence. * [fix] minor sentence. * [fix] minor sentence. * [fix] minor sentence. * Lint korean docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See vuejs/vue#7140
Not sure if it would be better to suggest one syntax over the other - I can see them both being useful for different things.