Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(url): call afterEach hooks after url is ensured #2292

Merged
merged 2 commits into from
May 26, 2020
Merged

feat(url): call afterEach hooks after url is ensured #2292

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07a3d55
feat(url): call afterEach hooks after url is ensured
posva Jul 10, 2018
3c4c890
Merge branch 'dev' into feat/2079/aftereach-url
posva May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/history/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,13 @@ export class History {
this.confirmTransition(
route,
() => {
const prev = this.current
this.updateRoute(route)
onComplete && onComplete(route)
this.ensureURL()
this.router.afterHooks.forEach(hook => {
hook && hook(route, prev)
})

// fire ready cbs once
if (!this.ready) {
Expand Down Expand Up @@ -214,12 +218,8 @@ export class History {
}

updateRoute (route: Route) {
const prev = this.current
this.current = route
this.cb && this.cb(route)
this.router.afterHooks.forEach(hook => {
hook && hook(route, prev)
})
}

setupListeners () {
Expand Down