fix: handle null values when comparing objects (#1568)

Fix #1566
vuejs · Oct 11, 2017 · 4e95bd8 · 4e95bd8
1 parent 1422eb5
commit 4e95bd8
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/util/route.js b/src/util/route.js
@@ -74,6 +74,8 @@ export function isSameRoute (a: Route, b: ?Route): boolean {
 }
 
 function isObjectEqual (a = {}, b = {}): boolean {
+  // handle null value #1566
+  if (!a || !b) return a === b
   const aKeys = Object.keys(a)
   const bKeys = Object.keys(b)
   if (aKeys.length !== bKeys.length) {

diff --git a/test/unit/specs/route.spec.js b/test/unit/specs/route.spec.js
@@ -47,6 +47,25 @@ describe('Route utils', () => {
       expect(isSameRoute(a, b)).toBe(true)
       expect(isSameRoute(a, c)).toBe(false)
     })
+
+    it('queries with null values', () => {
+      const a = {
+        path: '/abc',
+        query: { foo: null }
+      }
+      const b = {
+        path: '/abc',
+        query: { foo: null }
+      }
+      const c = {
+        path: '/abc',
+        query: { foo: 5 }
+      }
+      expect(() => isSameRoute(a, b)).not.toThrow()
+      expect(() => isSameRoute(a, c)).not.toThrow()
+      expect(isSameRoute(a, b)).toBe(true)
+      expect(isSameRoute(a, c)).toBe(false)
+    })
   })
 
   describe('isIncludedRoute', () => {