chore: add fixme comments to address issues with specific project names

vuejs · Nov 30, 2020 · 99a5196 · 99a5196
1 parent e750609
commit 99a5196
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/pluginWebpack4.ts b/src/pluginWebpack4.ts
@@ -46,6 +46,7 @@ class VueLoaderPlugin implements webpack.Plugin {
     const vueUse = vueRule.use as webpack.RuleSetLoader[]
     // get vue-loader options
     const vueLoaderUseIndex = vueUse.findIndex((u) => {
+      // FIXME: this code logic is incorrect when project paths starts with `vue-loader-something`
       return /^vue-loader|(\/|\\|@)vue-loader/.test(u.loader || '')
     })
 

diff --git a/src/pluginWebpack5.ts b/src/pluginWebpack5.ts
@@ -134,6 +134,7 @@ class VueLoaderPlugin implements Plugin {
 
     // get vue-loader options
     const vueLoaderUseIndex = vueUse.findIndex((u) => {
+      // FIXME: this code logic is incorrect when project paths starts with `vue-loader-something`
       return /^vue-loader|(\/|\\|@)vue-loader/.test(u.loader)
     })