Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lang='tsx' doesn't work for Vue 3 SFC #547

Merged
merged 1 commit into from
Aug 6, 2023
Merged

fix: lang='tsx' doesn't work for Vue 3 SFC #547

merged 1 commit into from
Aug 6, 2023

Conversation

sevilyilmaz
Copy link
Contributor

Applies the same fix that is added for Vue 2 with this PR: #395

Resolves #510

Applies the same fix for Vue 2 with this PR: #395

Resolves #510
@sevilyilmaz
Copy link
Contributor Author

@lmiller1990 @cexbrayat could you check this PR? (Pinging you as I'm not sure if you already got a notification or not)

@cexbrayat
Copy link
Member

LGTM (but I no longer actively maintain this as we switched to vitest to run our tests)

@sevilyilmaz
Copy link
Contributor Author

sevilyilmaz commented Aug 1, 2023

I understand the reasoning.

It would be great to have PRs for bug fixes reviewed and released. Because it’s not straightforward to switch to vitest especially in big monorepos

@lmiller1990
Copy link
Member

I too do not really use / maintain this, but I will review and release your fix, give me until the end of the week (5th or 6th of Aug).

We really need someone who is actively invested in this repo, for now I'm happy to do the minimum of review / release patches, but I only check when someone pings me.

@lmiller1990 lmiller1990 merged commit b3238b2 into vuejs:master Aug 6, 2023
@lmiller1990
Copy link
Member

@sevilyilmaz
Copy link
Contributor Author

@lmiller1990 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to add support for lang="tsx" in sfc?
3 participants